Changeset 8235

Timestamp:

02/13/2019 01:50:37 AM (6 years ago)

Author:

iandunn

Message:

WordCamp Post Type: Check POST action earlier to avoid false positive.

Previously, if you manually added a new wordcamp post type, you would get the fatal nonce validation error, even though it doesn't make sense to check the nonce in that context.

Related: r8133 / r8135, r8220.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php

@@ -422 +422 @@
         }
 
+        // Don't add/remove meta on trash, untrash, restore, etc.
+        if ( empty( $_POST['action'] ) || 'editpost' !== $_POST['action'] ) {
+            return;
+        }
+
         // Make sure the request came from the edit post screen.
         if ( $verify_nonce ) {
@@ -429 +434 @@
         }
 
-        // Don't add/remove meta on trash, untrash, restore, etc.
-        if ( empty( $_POST['action'] ) || 'editpost' !== $_POST['action'] ) {
-            return;
-        }
 
         $meta_keys = $this->meta_keys();