Making WordPress.org

Changeset 8235


Ignore:
Timestamp:
02/13/2019 01:50:37 AM (5 years ago)
Author:
iandunn
Message:

WordCamp Post Type: Check POST action earlier to avoid false positive.

Previously, if you manually added a new wordcamp post type, you would get the fatal nonce validation error, even though it doesn't make sense to check the nonce in that context.

Related: r8133 / r8135, r8220.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php

    r8220 r8235  
    422422        }
    423423
     424        // Don't add/remove meta on trash, untrash, restore, etc.
     425        if ( empty( $_POST['action'] ) || 'editpost' !== $_POST['action'] ) {
     426            return;
     427        }
     428
    424429        // Make sure the request came from the edit post screen.
    425430        if ( $verify_nonce ) {
     
    429434        }
    430435
    431         // Don't add/remove meta on trash, untrash, restore, etc.
    432         if ( empty( $_POST['action'] ) || 'editpost' !== $_POST['action'] ) {
    433             return;
    434         }
    435436
    436437        $meta_keys = $this->meta_keys();
Note: See TracChangeset for help on using the changeset viewer.