Context Navigation

Changeset 8254

Timestamp:

02/15/2019 03:54:03 AM (7 years ago)

Author:

dd32

Message:

Support: Move the update-php strings from the Helphub to the Support Theme for easier usage by locales.

This also switches the page template used from page.php to page-full-width.php on non-en_US sites to avoid some edgecases.

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

r8071	r8254
24	24	require_once( dirname( __FILE__ ) . '/inc/helphub-customroles/class-helphub-custom-roles.php' );
25	25	require_once( dirname( __FILE__ ) . '/inc/helphub-manager/class-helphub-manager.php' );
26		~~require_once( dirname( __FILE__ ) . '/inc/helphub-update-php/helphub-update-php.php' );~~

r8208	r8254
811	811	}
812	812
	813	/**
	814	* Include the Strings for the supporg/update-php page.
	815	*/
	816	include_once __DIR__ . '/helphub-update-php-strings.php';

-              r8253
+              r8254
  * @return string Filtered post title.
  */
 function hh_filter_update_php_title( $title, $id ) {
+function wporg_support_filter_update_php_title( $title, $id ) {
         if ( is_admin() ) {
                 return $title;
 …
         return __( 'Get a faster, more secure website: update your PHP today', 'wporg-forums' );
+}
 add_filter( 'the_title', 'hh_filter_update_php_title', 5, 2 );
+add_filter( 'the_title', 'wporg_support_filter_update_php_title', 5, 2 );
 /**
 …
  * @return string Filtered post content.
  */
 function hh_filter_update_php_content( $content ) {
+function wporg_support_filter_update_php_content( $content ) {
         if ( is_admin() ) {
                 return $content;
+        }
         if ( ! is_page_template( 'page-update-php.php' ) ) {
+        if ( ! in_the_loop() || get_the_ID() !== get_queried_object_id() ) {
                 return $content;
+        }
         if ( ! in_the_loop() || get_the_ID() !== get_queried_object_id() ) {
+        if ( ! is_page_template( 'page-update-php.php' ) ) {
                 return $content;
+        }
 …
         return $content;
+}
 add_filter( 'the_content', 'hh_filter_update_php_content', 5 );
+add_filter( 'the_content', 'wporg_support_filter_update_php_content', 5 );

-              r8071
+              r8254
 /*
 Use the default template for pages. This specific template is only used to indicate that the content needs to be
 manually injected, which happens in the HelpHub plugin.
+manually injected, which happens in `helphub-update-php-strings.php`
  */
+require get_stylesheet_directory() . '/page.php';
+if ( 'en_US' == get_locale() ) {
+        // Helphub will be active, so we need it's sidebar
+        require get_stylesheet_directory() . '/page.php';
+} else {
+        // Helphub may be active, but we're loading in a non-en_US locale so shouldn't display the EN sidebar
+        require get_stylesheet_directory() . '/page-full-width.php';
+}

Note: See TracChangeset for help on using the changeset viewer.