Changeset 8256

Timestamp:

02/15/2019 07:16:16 AM (8 years ago)

Author:

dd32

Message:

Translate: Update the plugin translate stats overview to only use the Code project, as many locales do not translate the entire readme which results in a skewed stats page.

A toggle may be included in the future, or a separate view for Readme status.

See #2290.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins

Files:

• wporg-gp-customizations/templates/stats-plugin-themes-overview.php (modified) (1 diff)
• wporg-gp-routes/inc/routes/class-stats.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/stats-plugin-themes-overview.php

@@ -5 +5 @@
 $breadcrumb   = array();
 $breadcrumb[] = gp_link_get( '/stats', __( 'Locale Stats' ) );
-$breadcrumb[] = gp_link_get( '/locales/' . $locale . '/' . $locale_slug, $gp_locale->native_name );
+$breadcrumb[] = gp_link_get( '/locale/' . $locale . '/' . $locale_slug, $gp_locale->english_name );
 $breadcrumb[] = trim( ucwords( $view ), 's' ) . ' translation status overview';
 gp_breadcrumb( $breadcrumb );

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-stats.php

@@ -195 +195 @@
                         }
 
-                        if (
-                                'plugins' == $view &&
-                                (
-                                        ! GP::$project->by_path( $items[$slug]->project->path . '/dev' )
-                                        &&
-                                        ! GP::$project->by_path( $items[$slug]->project->path . '/stable' )
-                                )
-                        ) {
-                                // Not all top plugins are translation-aware, lets just skip those..
-                                unset( $items[ $slug ] );
-                                continue;
-                        }
-
-                        $project_ids[ $items[$slug]->project->id ] = $slug;
+                        if ( 'plugins' == $view ) {
+                                // For plugins, we're ignoring the Readme projects as they're not immediately useful.
+                                // The display will use the "Code Stable" if present, else "Code Development"
+                                $code_project =
+                                        GP::$project->by_path( 'wp-' . $view . '/' . $slug . '/stable' ) ?:
+                                        GP::$project->by_path( 'wp-' . $view . '/' . $slug . '/dev' );
+
+                                // No code project? This happens when the plugin isn't translatable. The readme projects still exist though.
+                                if ( ! $code_project ) {
+                                        unset( $items[ $slug ] );
+                                        continue;
+                                }
+
+                                $project_ids[ $code_project->id ] = $slug;
+                        } else {
+                                $project_ids[ $items[$slug]->project->id ] = $slug;
+                        }
                 }
 
@@ -219 +222 @@
                         $locale, $locale_slug
                 ) );
+
+                // Link Projects & Stats
                 foreach ( $stats as $row ) {
                         $items[ $project_ids[ $row->project_id ] ]->stats = $row;
+                }
+
+                // Final sanity check that we have data to display.
+                foreach ( $items as $slug => $details ) {
+                        if (
+                                ! isset( $details->stats ) || // Didn't find any cached data for a project
+                                ! $details->stats->all // Project has no strings, not useful for this interface
+                        ) {
+                                unset( $items[ $slug ] );
+                        }
                 }