Changeset 8260

Timestamp:

02/15/2019 08:50:48 PM (8 months ago)

Author:

coreymckrill

Message:

WordCamp: Add control operator check to custom error handler

This should ensure that expressions that include explicit error suppression,
such as @opendir and @closedir, are in fact suppressed when their errors are
piped through our custom error handler.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php

@@ -462 +462 @@
  */
 function send_error_to_slack( $err_no, $err_msg, $file, $line ) {
-
     if ( ! init_error_handling() ) {
+        return false;
+    }
+
+    // Checks to see if the error-throwing expression is prepended with the @ control operator.
+    // See https://secure.php.net/manual/en/function.set-error-handler.php
+    if ( 0 === error_reporting() ) {
         return false;
     }
@@ -486 +491 @@
         // See https://core.trac.wordpress.org/ticket/29204
         ABSPATH . 'wp-includes/SimplePie/Registry.php:215' => 'Non-static method WP_Feed_Cache::create() should not be called statically',
-
-        // It seems like WPSC shouldn't assume that these files/folders always exist, and should check first instead.
-        WP_CONTENT_DIR . '/plugins/wp-super-cache/wp-cache-phase2.php:2359' => 'failed to open dir: No such file or directory',
-        WP_CONTENT_DIR . '/plugins/wp-super-cache/wp-cache-phase2.php:2901' => 'failed to open dir: No such file or directory',
-        WP_CONTENT_DIR . '/plugins/wp-super-cache/wp-cache-phase2.php:3033' => 'No such file or directory',
     ];