Changeset 8271

Timestamp:

02/18/2019 11:49:56 PM (7 years ago)

Author:

iandunn

Message:

WordCamp Organizer Reminders: Use empty array as default sent email IDs.

The previous code attempted to do this by casting the result to an array, but that accidentally created an array where the first value was an empty string -- i.e., array( 0 => '' ) -- because get_post_meta() returns an empty string when $single is false.

In order to correctly end up with an empty array, the code needs to explicitly check that the returned value isn't already an array.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php

@@ -502 +502 @@
 
         foreach ( $wordcamps as $wordcamp ) {
-            $sent_email_ids = (array) get_post_meta( $wordcamp->ID, 'wcor_sent_email_ids', true );
+            $sent_email_ids = get_post_meta( $wordcamp->ID, 'wcor_sent_email_ids', true );
+            if ( ! is_array( $sent_email_ids ) ) {
+                $sent_email_ids = array();
+            }
 
             foreach ( $reminder_emails as $email ) {