Changeset 8317

Timestamp:

02/22/2019 06:45:02 AM (6 years ago)

Author:

dd32

Message:

Translate: Add a custom warning to catch translated placeholders.

See ​https://core.trac.wordpress.org/ticket/46305
Fixes #4196.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-custom-warnings/wporg-gp-custom-warnings.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-custom-warnings/wporg-gp-custom-warnings.php

@@ -30 +30 @@
      * This allows for the scheme to change, and for WordPress.org URL's to change to a subdomain.
      *
-     * @param string $original    The orignal string.
+     * @param string $original    The original string.
      * @param string $translation The translated string.
      */
@@ -96 +96 @@
     }
 
+
+    /**
+     * Adds a warning for changing placeholders.
+     *
+     * This only supports placeholders in the format of '###[A-Z_]+###'.
+     *
+     * @param string $original    The original string.
+     * @param string $translation The translated string.
+     */
+    public function warning_mismatching_placeholders( $original, $translation ) {
+        $placeholder_regex = '@(###[A-Z_]+###)@';
+
+        preg_match_all( $placeholder_regex, $original, $original_placeholders );
+        $original_placeholders = array_unique( $original_placeholders[0] );
+
+        preg_match_all( $placeholder_regex, $translation, $translation_placeholders );
+        $translation_placeholders = array_unique( $translation_placeholders[0] );
+
+        $missing_placeholders = array_diff( $original_placeholders, $translation_placeholders );
+        $added_placeholders = array_diff( $translation_placeholders, $original_placeholders );
+        if ( ! $missing_placeholders && ! $added_placeholders ) {
+            return true;
+        }
+
+        // Error.
+        $error = '';
+        if ( $missing_placeholders ) {
+            $error .= "The translation appears to be missing the following placeholders: " . implode( ', ', $missing_placeholders ) . "\n";
+        }
+        if ( $added_placeholders ) {
+            $error .= "The translation contains the following unexpected placeholders: " . implode( ', ', $added_placeholders );
+        }
+
+        return trim( $error );
+    }
+
     /**
      * Registers all methods starting with warning_ with GlotPress.