Changeset 8374 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

Timestamp:

02/28/2019 03:34:07 PM (7 years ago)

Author:

vedjain

Message:

WCPT: Multiple minor fixes. See description.

1. Added check while sending declined / scheduled notifications for WordCamp / Meetup, so that we do not send duplicate notifications for same event.
2. Removed meetup organizer reminder cron because we are not using it anymore. This was already disabled, and this patch just removes dead code from codebase.
3. Applied code standard and fixes in multiple places.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -744 +744 @@
          * @param WP_Post $wordcamp
          *
-         * @return null|bool
+         * @return null|bool|string
          */
         public static function notify_new_wordcamp_in_slack( $wordcamp ) {
+            $scheduled_notification_key = 'sent_scheduled_notification';
+            if ( get_post_meta( $wordcamp->ID, $scheduled_notification_key, true ) ) {
+                return null;
+            }
+
             // Not translating any string because they will be sent to slack.
             $city             = get_post_meta( $wordcamp->ID, 'Location', true );
@@ -762 +767 @@
             $attachment = create_event_status_attachment( $message, $wordcamp->ID, $title );
 
-            return wcpt_slack_notify( COMMUNITY_EVENTS_SLACK, $attachment );
+            $notification_sent = wcpt_slack_notify( COMMUNITY_EVENTS_SLACK, $attachment );
+            if ( $notification_sent ) {
+                update_post_meta( $wordcamp->ID, $scheduled_notification_key, true );
+            }
+            return $notification_sent;
         }