Changeset 8474

Timestamp:

03/18/2019 02:49:56 AM (6 years ago)

Author:

dd32

Message:

Plugin Directory: Link directly to the Reviews rather than using the ?p= syntax.

Fixes #4286.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• class-tools.php (modified) (1 diff)
• shortcodes/class-reviews.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-tools.php

@@ -56 +56 @@
             $reviews = $wpdb->get_results( $wpdb->prepare(
                 "SELECT
-                    ID, post_content, post_title, post_author, post_modified,
+                    ID, post_name, post_content, post_title, post_author, post_modified,
                     r.rating as post_rating
                 FROM ratings r

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-reviews.php

@@ -31 +31 @@
             foreach ( $reviews as $review ) :
                 setup_postdata( $review );
+                if ( !empty( $review->post_name ) ) {
+                    $url = 'https://wordpress.org/support/topic/' . $review->post_name . '/';
+                } else {
+                    $url = add_query_arg( array( 'p' => $review->ID ), 'https://wordpress.org/support/plugin/' );
+                }
                 ?>
                 <article class="plugin-review">
@@ -37 +42 @@
                     </div><div class="review">
                         <header>
-                            <?php if ( ! empty( $review->ID ) ) : ?>
-                                <h3 class="review-title"><a class="url" href="<?php echo esc_url( add_query_arg( array( 'p' => $review->ID ), 'https://wordpress.org/support/plugin/' ) ); ?>"><?php echo get_the_title( $review ); ?></a></h3>
-                            <?php else : ?>
-                                <h3 class="review-title"><?php echo get_the_title( $review ); ?></h3>
-                            <?php endif; ?>
+                            <h3 class="review-title"><a class="url" href="<?php echo esc_url( $url ); ?>"><?php echo get_the_title( $review ); ?></a></h3>
                             <?php echo Template::dashicons_stars( $review->post_rating ); ?>
                             <span class="review-author author vcard"><?php the_author_posts_link(); ?></span>