Changeset 8488

Timestamp:

03/21/2019 11:29:36 PM (6 years ago)

Author:

coreymckrill

Message:

WordCamp MES: Simplify saving of post meta to avoid accidental data loss

When an MES post is saved, the save routine logic looks for specific keys in
$_POST and for the ones it finds, it updates related post meta fields. For
ones it doesn't find, it deletes related post meta fields.

When updating an MES from the Edit screen, this is fine because all of the
postmeta values have related metabox fields, so they will always be present
in $_POST during the save_post action. But when using Quick Edit, those
metaboxes don't exist, so everything gets deleted.

Removing the lines that delete post meta fields when they are not present
fixes this issue. This should be ok because the fields will still be updated
with empty values if the related fields are cleared on the Edit screen.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/multi-event-sponsors/classes/mes-sponsor.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/multi-event-sponsors/classes/mes-sponsor.php

@@ -215 +215 @@
             array_walk( $new_values[ 'mes_regional_sponsorships' ], 'absint' );
             update_post_meta( $post_id, 'mes_regional_sponsorships', $new_values[ 'mes_regional_sponsorships' ] );
-        } else {
-            delete_post_meta( $post_id, 'mes_regional_sponsorships' );
         }
 
@@ -231 +229 @@
             if ( isset( $new_values["mes_$field"] ) ) {
                 update_post_meta( $post_id, "mes_$field", sanitize_text_field( $new_values["mes_$field"] ) );
-            } else {
-                delete_post_meta( $post_id, "mes_$field" );
             }
         }
@@ -239 +235 @@
         if ( $sponsor_agreement ) {
             update_post_meta( $post_id, 'mes_sponsor_agreement', $sponsor_agreement );
-        } else {
-            delete_post_meta( $post_id, 'mes_sponsor_agreement' );
         }
     }