Making WordPress.org

Changeset 8525


Ignore:
Timestamp:
03/25/2019 10:24:51 PM (5 years ago)
Author:
coffee2code
Message:

Developer: Move auto-link exception handling into link_internal_element() so as to apply in a broader range of contexts.

Previous implementation only affected auto-linking in deprecation notice, but the need for the exception could also apply in text, param descriptions, see alsos, etc.

Props rahmohn, coffee2code.
See #4310.

Location:
sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/formatting.php

    r8466 r8525  
    170170        $url = '';
    171171
     172        // Exceptions for externally-linked elements.
     173        $exceptions = [
     174            'error_log()' => 'https://secure.php.net/manual/en/function.error-log.php',
     175        ];
     176
     177        // Link exceptions that should actually point to external resources.
     178        if ( ! empty( $exceptions[ $link ] ) ) {
     179            $url = $exceptions[ $link ];
     180        }
     181
    172182        // Link to class variable: {@see WP_Rewrite::$index}
    173         if ( false !== strpos( $link, '::$' ) ) {
     183        elseif ( false !== strpos( $link, '::$' ) ) {
    174184            // Nothing to link to currently.
    175185        }
  • sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php

    r8487 r8525  
    10641064                }
    10651065
    1066                 // Exceptions for externally-linked elements.
    1067                 $exceptions = [
    1068                     'error_log()' => 'https://secure.php.net/manual/en/function.error-log.php',
    1069                 ];
    1070                 if ( ! empty( $exceptions[ $refers ] ) ) {
    1071                     $link_to = \DevHub_Formatting::generate_link( $exceptions[ $refers ], $refers );
    1072                 }
    1073                 // Else internally-link the element.
    1074                 else {
    1075                     $link_to = \DevHub_Formatting::link_internal_element( $refers );
    1076                 }
    1077 
    10781066                /* translators: %s: Linked internal element name */
    1079                 $deprecation_info = ' ' . sprintf( __( 'Use %s instead.', 'wporg' ), $link_to );
     1067                $deprecation_info = ' ' . sprintf( __( 'Use %s instead.', 'wporg' ), \DevHub_Formatting::link_internal_element( $refers ) );
    10801068            }
    10811069        }
Note: See TracChangeset for help on using the changeset viewer.