Changeset 859

Timestamp:

09/12/2014 12:07:32 AM (9 years ago)

Author:

iandunn

Message:

WordCamp Organizer Reminders: Sync postmeta before replacing placeholders.

If the fields for a wordcamp post are updated at the same time that the post_status is changed to publish
then the values stored in postmeta are potentially out of sync with the new values being submitted in $_POST.

Another approach to solving this problem would have been to pull the data from either $_POST or
postmeta based on the current state, which would be more elegant than saving postmeta an additional time, but
that would also have required duplicating some of the metabox_save() logic, like converting date strings to
timestamps, which would violate the DRY principle.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php

@@ -148 +148 @@
      */
     protected function replace_placeholders( $wordcamp, $email, $content ) {
+        /** @var $wordcamp_admin WordCamp_Admin */
+        global $wordcamp_admin;
+
+        // Make sure postmeta is synced with $_POST when this is called in the middle of updating a post
+        if ( did_action( 'transition_post_status' ) || did_action( 'save_post' ) ) {
+            $wordcamp_admin->metabox_save( $wordcamp->ID );
+        }
+
         $wordcamp_meta = get_post_custom( $wordcamp->ID );