Changeset 8620 for sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

Timestamp:

04/10/2019 05:20:19 AM (6 years ago)

Author:

dd32

Message:

Support Forums: Create the plugin/theme term Just-in-time earlier in the page load to avoid the first-ever pageview for a plugin/theme support forum showing irrelevant topics.

This change also only creates terms for valid objects of that type, previously it was possible to create terms for objects that didn't yet exist.

Fixes #4342.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

@@ -290 +290 @@
             $this->term = get_term_by( 'slug', $this->slug(), $this->taxonomy() );
 
+            // New compats won't have any support topics or reviews, so will
+            // not yet exist as a compat term.
+            if ( ! $this->term && $this->get_object( $this->slug() ) ) {
+                $term = wp_insert_term( $this->slug(), $this->taxonomy() );
+                $this->term = get_term( $term['term_id'] );
+            }
+
             // Add plugin- and theme-specific filters and actions.
             add_action( 'wporg_compat_view_sidebar',       array( $this, 'do_view_sidebar' ) );
@@ -742 +749 @@
 
         $term_subscription = '';
-        $term = $this->term;
-        if ( ! $term ) {
+        if ( ! $this->term && $this->get_object( $this->slug() ) ) {
             // New compats won't have any support topics or reviews, so will
             // not yet exist as a compat term.
             $term = wp_insert_term( $this->slug(), $this->taxonomy() );
-            $term = get_term( $term['term_id'] );
-        }
-        if ( $term ) {
-            $this->term = $term;
+            $this->term = get_term( $term['term_id'] );
+        }
+        if ( $this->term ) {
             $subscribe = $unsubscribe = '';
             if ( 'plugin' == $this->compat() ) {
@@ -760 +765 @@
             }
             $term_subscription = Term_Subscription\Plugin::get_subscription_link( array(
-                'term_id'     => $term->term_id,
+                'term_id'     => $this->term->term_id,
                 'taxonomy'    => $this->taxonomy(),
                 'subscribe'   => $subscribe,