Changeset 8640 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php

Timestamp:

04/16/2019 07:04:32 AM (7 years ago)

Author:

ocean90

Message:

Translate: Extract JavaScript translations from admin files for WordPress 5.2+.

See #3748.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php

@@ -52 +52 @@
                         WP_CLI::error( 'Unsupported WordPress version. Use makepot.php.' );
                 }
-
-                $extract_js = version_compare( $wp_version, '5.0-beta', '>=' );
 
                 $dry_run = Utils\get_flag_value( $assoc_args, 'dry-run', false );
@@ -114 +112 @@
                 $command .= ' --ignore-domain';
 
-                if ( ! $extract_js ) {
+                if ( version_compare( $wp_version, '5.0-beta', '<' ) ) {
                         $command .= ' --skip-js';
                 }
@@ -161 +159 @@
                 $command .= ' --headers=' . escapeshellarg( $headers );
                 $command .= ' --file-comment=' . escapeshellarg( $file_comment );
-                $command .= ' --skip-js'; // TODO: No use of wp.i18n, yet.
-                $command .= ' --skip-audit';
-                $command .= ' --ignore-domain';
+                $command .= ' --skip-audit';
+                $command .= ' --ignore-domain';
+
+                if ( version_compare( $wp_version, '5.2-beta', '<' ) ) {
+                        $command .= ' --skip-js';
+                }
 
                 WP_CLI::line( $command );