Changeset 8699 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/camptix-invoices/includes/class-camptix-addon-invoices.php

Timestamp:

04/26/2019 06:21:50 PM (6 years ago)

Author:

coreymckrill

Message:

WordCamp invoices: Fix bug with invoice numbering

This changes the process of creating an invoice to avoid generating more
than one unique invoice number. The number is determined during the save_post
hook, so it doesn't need to happen during the create_invoice method itself.

Props avillegasn

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/camptix-invoices/includes/class-camptix-addon-invoices.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/camptix-invoices/includes/class-camptix-addon-invoices.php

@@ -273 +273 @@
      */
     public static function create_invoice( $attendee, $order, $metas ) {
-        $number         = self::create_invoice_number();
+
+        $invoice = array(
+            'post_type'   => 'tix_invoice',
+            'post_status' => 'draft',
+        );
+
+        $invoice_id = wp_insert_post( $invoice );
+        if ( ! $invoice_id || is_wp_error( $invoice_id ) ) {
+            return;
+        }//end if
+
+        $number         = get_post_meta( $invoice_id, 'invoice_number', true );
         $attendee_email = get_post_meta( $attendee->ID, 'tix_email', true );
         $txn_id         = get_post_meta( $attendee->ID, 'tix_transaction_id', true );
@@ -300 +311 @@
         }//end if
 
-        $invoice = array(
-            'post_type'   => 'tix_invoice',
-            'post_status' => 'draft',
-            'post_title'  => $invoice_title,
-            'post_name'   => sprintf( 'invoice-%s', $number ),
-        );
-
-        $invoice_id = wp_insert_post( $invoice );
-        if ( ! $invoice_id || is_wp_error( $invoice_id ) ) {
-            return;
-        }//end if
-        update_post_meta( $invoice_id, 'invoice_number', $number );
         update_post_meta( $invoice_id, 'invoice_metas', $metas );
         update_post_meta( $invoice_id, 'original_order', $order );
@@ -320 +319 @@
                 'ID'          => $invoice_id,
                 'post_status' => 'publish',
+                'post_title'  => $invoice_title,
+                'post_name'   => sprintf( 'invoice-%s', $number ),
             )
         );