Changeset 8794

Timestamp:

05/15/2019 06:32:48 AM (6 years ago)

Author:

dd32

Message:

Theme Directory: Sanitize version numbers in the Theme readme.txt import process.

A number of themes include extra details in the fields such as 'WordPress', and others don't follow the plugin/theme readme stanard at all, this change validates the data a little more before importing.

It also removes the importing of the 'Tags' header as there's no immediate plans for it's use and we defer to the style.css Tags header instead.

See #3718.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -93 +93 @@
         'requires'     => 'requires at least',
         'requires_php' => 'requires php',
-        'readme_tags'  => 'tags',
         'contributors' => 'contributors',
         'license'      => 'license',
@@ -434 +433 @@
             if ( ! $data['contributors'] ) {
                 unset( $data['contributors'] );
+            }
+        }
+
+        // Sanitize some version-like data.
+        foreach ( array( 'requires', 'requires_php', 'tested' ) as $field ) {
+            if ( ! isset( $data[ $field ] ) ) {
+                continue;
+            }
+
+            // Strip 'WP', 'WordPress', and 'PHP' from the fields.
+            $data[ $field ] = trim( str_ireplace( array( 'PHP', 'WP', 'WordPress', '+' ), '', $data[ $field ] ) );
+
+            // Require a version-like value, x.y or x.y.z
+            if ( ! preg_match( '!^\d+\.\d(\.\d+)?$!', $data[ $field ] ) ) {
+                unset( $data[ $field ] );
+                continue;
+            }
+
+            // Allow themes to mark themselves as compatible with Stable+0.1 (trunk/master) but not higher
+            if (
+                ( 'requires' === $field || 'tested' === $field ) &&
+                defined( 'WP_CORE_STABLE_BRANCH' ) &&
+                version_compare( (float)$data[ $field ], (float)WP_CORE_STABLE_BRANCH+0.1, '>' )
+            ) {
+                unset( $data[ $field ] );
+                continue;
             }
         }