Changeset 8905

Timestamp:

06/03/2019 03:21:30 AM (5 years ago)

Author:

dd32

Message:

Trac Notifications: Handle API failures in the ​https://make.wordpress.org/core/components/ UI.

Currently when Trac fails to respond in a reasonable timeframe it generates a PHP Warning and the UI is slightly off.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php (modified) (6 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php

@@ -400 +400 @@
 
         $followers = $this->api->get_component_followers( $post->post_title );
-        $followers = "'" . implode( "', '", esc_sql( $followers ) ) . "'";
-        $followers = $wpdb->get_results( "SELECT user_login, user_nicename, user_email FROM $wpdb->users WHERE user_login IN ($followers)" );
+        if ( $followers ) {
+            $followers = "'" . implode( "', '", esc_sql( $followers ) ) . "'";
+            $followers = $wpdb->get_results( "SELECT user_login, user_nicename, user_email FROM $wpdb->users WHERE user_login IN ($followers)" );
+        }
         if ( $followers ) {
             echo 'Contributors following this component:';
@@ -484 +486 @@
 
         $history = $this->api->get_component_history( $component, self::last_x_days );
+        if ( ! $history ) {
+            $history = array( 'change' => 0 ); // Incorrect, but allows full page render.
+        }
+
         $direction = '';
         if ( $history['change'] > 0 ) {
@@ -555 +561 @@
 
         $tickets_by_type = $this->api->get_ticket_counts_for_component( $component );
+        if ( ! $tickets_by_type ) {
+            $tickets_by_type = array( 'defect (bug)' => 0 ); // Incorrect, but allows page render
+        }
 
         $count = array_sum( $tickets_by_type );
@@ -638 +647 @@
         if ( in_array( 'component', $topics ) ) {
             $components = $this->api->get_components();
-            foreach ( $components as $component ) {
-                echo '<option value="component/' . esc_attr( rawurlencode( $component ) ) . '">' . esc_html( $component ) . "</option>";
+            if ( $components ) {
+                foreach ( $components as $component ) {
+                    echo '<option value="component/' . esc_attr( rawurlencode( $component ) ) . '">' . esc_html( $component ) . "</option>";
+                }
             }
         }
@@ -652 +663 @@
         }
 
+        $component = $post->post_title;
+        $history = $this->api->get_component_history( $component );
+
+        if ( ! $history ) {
+            return;
+        }
+
         static $once = true;
         if ( $once ) {
@@ -657 +675 @@
             echo '<thead><tr><td>Component</td><td>Tickets</td><td>7 Days</td><td>0&nbsp;Replies</td><td>Maintainers</td></tr></thead>';
         }
-
-        $component = $post->post_title;
-        $history = $this->api->get_component_history( $component );
 
         $arrow = '';