Changeset 8906

Timestamp:

06/03/2019 02:36:38 PM (5 years ago)

Author:

vedjain

Message:

WordCamp: Rename methods to reduce ambiguity.

The method published_speaker_post_updated and speaker_post_published_or_unpublished actually effects both speaker and organizer post types, instead of just speaker.

This patch renames them to remove speaker keyword to reduce confusion.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-participation-notifier/wordcamp-participation-notifier.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-participation-notifier/wordcamp-participation-notifier.php

@@ -45 +45 @@
 
         if ( 'publish' == $new_status && 'publish' == $old_status ) {
-            $this->published_speaker_post_updated( $post );
+            $this->published_post_updated( $post );
         } elseif ( 'publish' == $new_status || 'publish' == $old_status ) {
-            $this->speaker_post_published_or_unpublished( $new_status, $old_status, $post );
+            $this->post_published_or_unpublished( $new_status, $old_status, $post );
         }
     }
@@ -117 +117 @@
      * @param WP_Post $post
      */
-    protected function published_speaker_post_updated( $post ) {
+    protected function published_post_updated( $post ) {
         $previous_user_id = $this->get_saved_wporg_user_id( $post );
         $new_user_id      = $this->get_new_wporg_user_id( $post );
@@ -157 +157 @@
      * @param WP_Post $post
      */
-    protected function speaker_post_published_or_unpublished( $new_status, $old_status, $post ) {
+    protected function post_published_or_unpublished( $new_status, $old_status, $post ) {
         if ( 'publish' == $new_status ) {
             $this->remote_post( self::PROFILES_HANDLER_URL, $this->get_post_activity_payload( $post ) );