Changeset 8908 for sites/trunk/wordcamp.org/public_html/wp-content/plugins

Timestamp:

06/03/2019 02:36:52 PM (7 years ago)

Author:

vedjain

Message:

WC Participant Notifier: Code review fixes. See desc:

1. Use is_post_notifiable to make code DRY
2. Better descriptive code comment.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-participation-notifier/wordcamp-participation-notifier.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-participation-notifier/wordcamp-participation-notifier.php

@@ -113 +113 @@
          * or organizer post changes.
          *
-         * IMPORTANT NOTE: If a draft post is published via block editor, we will have to add badges and activity here instead of `post_published_or_unpublished` method.
+         * IMPORTANT NOTE: When a draft post is published via the block editor, badges and activity must be managed here instead of in the `post_published_or_unpublished` method.
          * This is because when post is updated via Block editor, the status change request will not have any POST data, see @link https://github.com/WordPress/gutenberg/issues/12897
          *
@@ -174 +174 @@
          */
         protected function add_badge( $post, $user_id ) {
-                if ( ! in_array( $post->post_type, [ 'wcb_speaker', 'wcb_organizer' ] ) || ! $user_id ) {
+                if ( ! $this->is_post_notifiable( $post ) ) {
                         return;
                 }
@@ -199 +199 @@
                 global $wpdb;
 
-                if ( ! in_array( $post->post_type, [ 'wcb_speaker', 'wcb_organizer' ] ) ) {
+                if ( ! $this->is_post_notifiable( $post ) ) {
                         return;
                 }