Changeset 8918

Timestamp:

06/05/2019 04:34:52 AM (6 years ago)

Author:

dd32

Message:

Plugin Directory: Jobs: Update the Tested-up-to version in the API update-check endpoints when the plugin directory automatically bumps the tested-up-to value for plugins.

This also runs the 'Meta Sync' cron task whenever a new WordPress release is made, to help speed up the rate at which Plugins show the latest version in their 'tested' fields.

Fixes #4468.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• class-plugin-directory.php (modified) (1 diff)
• jobs/class-manager.php (modified) (2 diffs)
• jobs/class-meta-sync.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -885 +885 @@
             }
 
-            // Trim off special characters, only allowing wordy characters at the end of searches.s
+            // Trim off special characters, only allowing wordy characters at the end of searches.
             $s = preg_replace( '!(\W+)$!i', '', $s );
             // ..and whitespace

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-manager.php

@@ -234 +234 @@
      *
      * The jobs are queued for 1 minutes time to avoid recurring job failures from repeating too soon.
+     *
+     * This method is called on wp-admin pageviews and on a two-minutely cron task.
      */
     public function register_cron_tasks() {
@@ -249 +251 @@
         }
         if ( ! wp_next_scheduled( 'plugin_directory_check_cronjobs' ) ) {
+            // This function
             wp_schedule_event( time() + 60, 'every_120s', 'plugin_directory_check_cronjobs' );
         }
         if ( ! wp_next_scheduled ( 'plugin_directory_translation_sync' ) ) {
             wp_schedule_event( time() + 60, 'daily', 'plugin_directory_translation_sync' );
+        }
+
+        // Check to see if `WP_CORE_LATEST_RELEASE` has changed since we last ran.
+        if ( defined( 'WP_CORE_LATEST_RELEASE' ) && get_option( 'plugins_last_core_release_seen' ) !== WP_CORE_LATEST_RELEASE ) {
+            update_option( 'plugins_last_core_release_seen', WP_CORE_LATEST_RELEASE );
+
+            // If the next "Meta Sync" is more than 5 minutes away, perform one ASAP.
+            if ( wp_next_scheduled( 'plugin_directory_meta_sync' ) > ( time() + 5 * MINUTE_IN_SECONDS ) ) {
+                wp_schedule_single_event( time() + 10, 'plugin_directory_meta_sync' );
+            }
         }
     }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php

@@ -107 +107 @@
         }
 
-        $equivs     = wporg_get_version_equivalents();
-        $equivs_key = md5( serialize( $equivs ) );
-        if ( $equivs_key === get_option( 'plugin_last_tested_sync' ) ) {
-            return;
-        }
+        $equivs = wporg_get_version_equivalents();
 
         $latest_equiv = array();
@@ -121 +117 @@
 
         $tested_meta_value_esc_sql = '"' . implode( '", "', array_map( 'esc_sql', array_keys( $latest_equiv ) ) ) . '"';
-        $tested_values             = $wpdb->get_results( "SELECT post_id, meta_value FROM {$wpdb->postmeta} WHERE meta_key = 'tested' AND meta_value IN( {$tested_meta_value_esc_sql} )" );
+        $tested_values             = $wpdb->get_results( "SELECT post_id, post_name, meta_value FROM {$wpdb->postmeta} pm JOIN {$wpdb->posts} p ON pm.post_id = p.ID WHERE meta_key = 'tested' AND meta_value IN( {$tested_meta_value_esc_sql} )" );
 
         foreach ( $tested_values as $row ) {
@@ -129 +125 @@
                 $latest_equiv[ $row->meta_value ]
             );
+
+            // Update the API endpoints with the new data
+            API_Update_Updater::update_single_plugin( $row->post_name );
         }
-
-        update_option( 'plugin_last_tested_sync', $equivs_key );
     }
 }