Changeset 9018 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-stats.php

Timestamp:

07/02/2019 07:41:56 AM (7 years ago)

Author:

dd32

Message:

Translate: Stats overview: Cache a failure to fetch the top plugins/themes to prevent endless requests.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-stats.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-stats.php

@@ -152 +152 @@
                         // Fetch top 100 plugins..
                         $items = get_transient( __METHOD__ . '_plugin_items' );
-                        if ( ! $items ) {
+                        if ( false === $items ) {
                                 $api = wp_safe_remote_get( 'https://api.wordpress.org/plugins/info/1.2/?action=query_plugins&request[per_page]=250' );
+                                $items = array();
                                 foreach ( json_decode( wp_remote_retrieve_body( $api ) )->plugins as $plugin ) {
                                         $items[ $plugin->slug ] = (object) [
@@ -159 +160 @@
                                         ];
                                 }
-                                set_transient( __METHOD__ . '_plugin_items', $items, DAY_IN_SECONDS );
+                                set_transient( __METHOD__ . '_plugin_items', $items, $items ? DAY_IN_SECONDS : 5 * MINUTE_IN_SECONDS );
                         }
                 } elseif ( 'themes' == $view && defined( 'WPORG_THEME_DIRECTORY_BLOGID' ) ) {
                         $items = get_transient( __METHOD__ . '_theme_items' );
-                        if ( ! $items ) {
+                        if ( false === $items ) {
                                 // The Themes API API isn't playing nice.. Easiest way..
                                 switch_to_blog( WPORG_THEME_DIRECTORY_BLOGID );
@@ -179 +180 @@
                                         unset( $items[$slug]->slug );
                                 }
-                                set_transient( __METHOD__ . '_theme_items', $items, DAY_IN_SECONDS );
+                                set_transient( __METHOD__ . '_theme_items', $items, $items ? DAY_IN_SECONDS : 5 * MINUTE_IN_SECONDS );
                         }
                 } else {