Changeset 9024

Timestamp:

07/05/2019 07:11:27 AM (6 years ago)

Author:

dd32

Message:

Plugin Directory: Tools: SVN: Define all variables used within compact() to avoid PHP 7.3 notices.

Eg: Notice: compact(): Undefined variable: revision.

See [9012] which was rather incomplete in this class.
See ​https://wiki.php.net/rfc/compact.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tools/class-svn.php (modified) (8 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tools/class-svn.php

@@ -39 +39 @@
             $revision = (int) $m['revision'];
             $result   = true;
-        } else {
-            $result = false;
-            $errors = self::parse_svn_errors( $output );
+            $errors   = false;
+        } else {
+            $result   = false;
+            $revision = false;
+            $errors   = self::parse_svn_errors( $output );
         }
 
@@ -73 +75 @@
             $errors   = false;
         } else {
-            $result = false;
-            $errors = self::parse_svn_errors( $output );
+            $result   = false;
+            $revision = false;
+            $errors   = self::parse_svn_errors( $output );
         }
 
@@ -104 +107 @@
             $revision = (int) $m['revision'];
             $result   = true;
-        } else {
-            $result = false;
-            $errors = self::parse_svn_errors( $output );
+            $errors   = false;
+        } else {
+            $result   = false;
+            $revision = false;
+            $errors   = self::parse_svn_errors( $output );
         }
 
@@ -134 +139 @@
             $revision = (int) $m['revision'];
             $result   = true;
-        } else {
-            $result = false;
-            $errors = self::parse_svn_errors( $output );
+            $errors   = false;
+        } else {
+            $result   = false;
+            $revision = false;
+            $errors   = self::parse_svn_errors( $output );
         }
 
@@ -161 +168 @@
         if ( preg_match( "/^A/i", $output ) ) {;
             $result   = true;
+            $errors   = false;
         } else {
             $result = false;
@@ -198 +206 @@
             $revision = (int) $m['revision'];
             $result   = true;
-        } else {
-            $result = false;
-            $errors = self::parse_svn_errors( $output );
+            $errors   = false;
+        } else {
+            $result   = false;
+            $revision = false;
+            $errors   = self::parse_svn_errors( $output );
         }
 
@@ -235 +245 @@
             $revision = (int) $m['revision'];
             $result   = true;
-        } else {
-            $result = false;
-            $errors = self::parse_svn_errors( $output );
+            $errors   = false;
+        } else {
+            $result   = false;
+            $revision = false;
+            $errors   = self::parse_svn_errors( $output );
         }
 
@@ -424 +436 @@
     }
 }
+