Changeset 9050 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-validator.php

Timestamp:

07/16/2019 05:55:10 AM (5 years ago)

Author:

dd32

Message:

Plugin Directory: Preference the Requires PHP and Requires at least headers defined in the Plugins .php header over the readme.txt values.

This also moves the missing fields in the readme.txt to being notes rather than warnings in the readme validator.

This matches the behaviour in WordPress 5.3, see ​#WP46938.
Fixes #4514.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-validator.php (modified) (7 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-validator.php

@@ -86 +86 @@
                 '<code>' . number_format( $latest_wordpress_version - 0.1, 1 ) . '</code>'
             );
-        } elseif ( empty( $readme->requires ) ) {
-            $warnings[] = sprintf(
-                /* translators: %s: plugin header tag */
-                __( 'The %s field is missing.', 'wporg-plugins' ),
-                '<code>Requires at least</code>'
-            );
         }
 
@@ -120 +114 @@
                 '<code>7.0</code>'
             );
-        } elseif ( empty( $readme->requires_php ) ) {
-            $warnings[] = sprintf(
-                /* translators: %s: plugin header tag */
-                __( 'The %s field is missing.', 'wporg-plugins' ),
-                '<code>Requires PHP</code>'
-            );
         }
+
         if ( empty( $readme->stable_tag ) ) {
             $warnings[] = sprintf(
@@ -152 +141 @@
 
         // Notes.
+        if ( empty( $readme->requires ) ) {
+            $notes[] = sprintf(
+                /* translators: %s: plugin header tag */
+                __( 'The %s field is missing. It should be defined here, or in your main plugin file.', 'wporg-plugins' ),
+                '<code>Requires at least</code>'
+            );
+        }
+
+        if ( empty( $readme->requires_php ) ) {
+            $notes[] = sprintf(
+                /* translators: %s: plugin header tag */
+                __( 'The %s field is missing. It should be defined here, or in your main plugin file.', 'wporg-plugins' ),
+                '<code>Requires PHP</code>'
+            );
+        }
+
         if ( empty( $readme->sections['faq'] ) ) {
             $notes[] = sprintf(
@@ -159 +164 @@
             );
         }
+
         if ( empty( $readme->sections['changelog'] ) ) {
             $notes[] = sprintf(
@@ -166 +172 @@
             );
         }
+
         if ( empty( $readme->upgrade_notice ) ) {
             $notes[] = sprintf(
@@ -173 +180 @@
             );
         }
+
         if ( empty( $readme->screenshots ) ) {
             $notes[] = sprintf(
@@ -180 +188 @@
             );
         }
+
         if ( empty( $readme->donate_link ) ) {
             $notes[] = __( 'No donate link was found', 'wporg-plugins' );