Changeset 9066

Timestamp:

07/19/2019 03:51:20 AM (5 years ago)

Author:

dd32

Message:

Support Forums: /topic/0/ isn't a valid url - It seems that bbPress isn't catching that this is a topic request and doesn't properly handle the request.

This change forces canonical to kick in instead, as the empty QVs are no longer set.

Fixes #4547.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php

@@ -100 +100 @@
         // Deindex Support Forum Feeds. bbPress hooks in way earlier than most Core feed functions..
         add_filter( 'request', array( $this, 'deindex_forum_feeds' ), 5 );
+
+        add_filter( 'request', array( $this, 'ignore_empty_query_vars' ) );
+
     }
 
@@ -971 +974 @@
         return $query_vars;
     }
+
+    /**
+     * Ignore certain empty set query vars.
+     *
+     * TODO: This is probably a bbPress bug in that it doesn't handle "empty" QVs well.
+     */
+    function ignore_empty_query_vars( $query_vars ) {
+        // bbPress query vars that sometimes have weird urls as a result.
+        $ignore_emptyish_values = [ 'topic', 'reply', 'forum', 'topic-tag', 'bbp_view' ];
+
+        foreach ( $ignore_emptyish_values as $q ) {
+            if ( isset( $query_vars[ $q ] ) && empty( $query_vars[ $q ] ) ) {
+                // It's set, but empty so not a useful QV?
+                unset( $query_vars[ $q ] );
+            }
+        }
+
+        return $query_vars;
+    }
+
 }