Changeset 9090

Timestamp:

08/05/2019 02:42:57 AM (5 years ago)

Author:

dd32

Message:

Helphub: Don't use the translated titles for post type slugs.

While in english it's fine, not all locales want the translated slugs and it doesn't fit the rest of WordPress.org where there are no translated slugs.

See #4575.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-helphub/inc/helphub-post-types/classes

Files:

• class-helphub-post-types-post-type.php (modified) (6 diffs)
• class-helphub-post-types.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-helphub/inc/helphub-post-types/classes/class-helphub-post-types-post-type.php

@@ -33 +33 @@
 
     /**
+     * The slug used in URLs for the post type items.
+     *
+     * @access public
+     * @since  1.0.0
+     * @var    string
+     */
+    public $single_slug;
+
+    /**
+     * The slug used in URLs for the archive of the post type.
+     *
+     * @access public
+     * @since  1.0.0
+     * @var    string
+     */
+    public $archive_slug;
+
+    /**
      * The post type singular label.
      *
@@ -78 +96 @@
      * @param string $plural The plural pronunciation of the post type name.
      * @param array $args The typical arguments allowed to register a post type.
+     * @param string $single_slug The 'singular' slug for the post type.
+     * @param string $archive_slug The 'archive' slug for the post type.
      * @param array $taxonomies The list of taxonomies that the post type is associated with.
      */
-    public function __construct( $post_type = 'thing', $singular = '', $plural = '', $args = array(), $taxonomies = array() ) {
+    public function __construct( $post_type = 'thing', $singular = '', $plural = '', $args = array(), $taxonomies = array(), $single_slug = false, $archive_slug = false ) {
         $this->post_type  = $post_type;
         $this->singular   = $singular;
@@ -86 +106 @@
         $this->args       = $args;
         $this->taxonomies = $taxonomies;
+
+        if ( ! $single_slug ) {
+            $single_slug = sanitize_title_with_dashes( $this->singular );
+        }
+        $this->single_slug  = apply_filters( 'helphub_single_slug', $single_slug );
+
+        if ( ! $archive_slug ) {
+            $archive_slug = sanitize_title_with_dashes( $this->plural );
+        }
+        $this->archive_slug = apply_filters( 'helphub_archive_slug', $archive_slug );
 
         add_action( 'init', array( $this, 'register_post_type' ) );
@@ -148 +178 @@
         );
 
-        $single_slug  = apply_filters( 'helphub_single_slug', sanitize_title_with_dashes( $this->singular ) );
-        $archive_slug = apply_filters( 'helphub_archive_slug', sanitize_title_with_dashes( $this->plural ) );
-
         $defaults = array(
             'labels'                => $labels,
@@ -159 +186 @@
             'query_var'             => true,
             'rewrite'               => array(
-                'slug' => $single_slug,
+                'slug' => $this->single_slug,
             ),
             'capability_type'       => 'post',
-            'has_archive'           => $archive_slug,
+            'has_archive'           => $this->archive_slug,
             'hierarchical'          => false,
             'supports'              => array( 'title', 'editor', 'excerpt', 'thumbnail', 'page-attributes', 'revisions' ),
@@ -168 +195 @@
             'menu_icon'             => 'dashicons-smiley',
             'show_in_rest'          => true,
-            'rest_base'             => $archive_slug,
+            'rest_base'             => $this->archive_slug,
             'rest_controller_class' => 'WP_REST_Posts_Controller',
         );

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-helphub/inc/helphub-post-types/classes/class-helphub-post-types.php

@@ -128 +128 @@
 
         $this->post_types['post']            = new HelpHub_Post_Types_Post_Type(
-            'post', __( 'Post', 'wporg-forums' ), __( 'Posts', 'wporg-forums' ), array(
+            'post',
+            __( 'Post', 'wporg-forums' ),
+            __( 'Posts', 'wporg-forums' ),
+            array(
                 'menu_icon' => 'dashicons-post',
-            )
+            ),
+            array(),
+            'post',
+            'posts'
         );
         $this->post_types['helphub_article'] = new HelpHub_Post_Types_Post_Type(
-            'helphub_article', __( 'Article', 'wporg-forums' ), __( 'Articles', 'wporg-forums' ), array(
+            'helphub_article',
+            __( 'Article', 'wporg-forums' ),
+            __( 'Articles', 'wporg-forums' ),
+            array(
                 'menu_icon' => 'dashicons-media-document',
-            )
+            ),
+            array(),
+            'article',
+            'articles'
         );
         $this->post_types['helphub_version'] = new HelpHub_Post_Types_Post_Type(
-            'helphub_version', __( 'WordPress Version', 'wporg-forums' ), __( 'WordPress Versions', 'wporg-forums' ), array(
+            'helphub_version',
+            __( 'WordPress Version', 'wporg-forums' ),
+            __( 'WordPress Versions', 'wporg-forums' ),
+            array(
                 'menu_icon' => 'dashicons-wordpress',
-            )
+            ),
+            array(),
+            'wordpress-version',
+            'wordpress-versions'
         );