Changeset 9121

Timestamp:

08/29/2019 06:25:06 PM (5 years ago)

Author:

coreymckrill

Message:

Slack: Remove the /deputies command and related user list

This command is no longer used, since there is now a Communities Deputies
member group managed through the Slack interface.

Location:

sites/trunk/common/includes/slack/announce

Files:

• config.php (modified) (1 diff)
• lib.php (modified) (1 diff)

sites/trunk/common/includes/slack/announce/config.php

@@ -373 +373 @@
     );
 }
-
-// This is not all deputies; it's only the ones who want to receive `/deputies` pings
-function get_pingable_wordcamp_deputies() {
-    return array(
-        '00Sleepy', '_DorsVenabili', 'adityakane', 'andreamiddleton', 'bph', 'brandondove', 'camikaos',
-        'chanthaboune', 'courtneypk', 'drebbits', 'francina', 'gounder', 'heysherie', 'hlashbrooke',
-        'karenalma', 'kcristiano', 'kdrewien', 'Kenshino', 'mayukojpn', 'mikelking', 'miss_jwo',
-        'nukaga', 'remediosgraphic', 'Savione', 'vc27', 'yaycheryl',
-
-        'coreymckrill', 'iandunn', // todo remove after testing
-    );
-}

sites/trunk/common/includes/slack/announce/lib.php

@@ -84 +84 @@
     }
 
-    if ( $data['command'] === '/deputies' ) {
-        $pingable_deputies = get_pingable_wordcamp_deputies();
+    if ( ! is_user_whitelisted( $user, $channel ) ) {
+        show_authorization( $user, $channel );
+        return;
+    }
 
-        if ( ! in_array( $user, $pingable_deputies, true ) ) {
-            return;
-        }
+    $command = 'channel';
+    if ( $data['command'] === '/here' ) {
+        $command = 'here';
+    } elseif ( $channel === 'privategroup' ) {
+        // @channel and @group are interchangeable, but still.
+        $command = 'group';
+    }
 
-        // TODO: Note that pinging users by `@username` is deprecated, and we have WordPress.org usernames in the above list.
-        // This should be upadted to ping users by the `<@U.....>` format.
-
-        $text = sprintf( "*/deputies:* %s\n_(CC: %s)_", $data['text'], '@' . implode( ', @', $pingable_deputies ) );
-    } else {
-        if ( ! is_user_whitelisted( $user, $channel ) ) {
-            show_authorization( $user, $channel );
-            return;
-        }
-
-        $command = 'channel';
-        if ( $data['command'] === '/here' ) {
-            $command = 'here';
-        } elseif ( $channel === 'privategroup' ) {
-            // @channel and @group are interchangeable, but still.
-            $command = 'group';
-        }
-
-        $text = sprintf( "<!%s> %s", $command, $data['text'] );
-    }
+    $text = sprintf( "<!%s> %s", $command, $data['text'] );
 
     $send = new Send( \Dotorg\Slack\Send\WEBHOOK );