Changeset 9128

Timestamp:

09/07/2019 10:02:20 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Plugin Directory Theme: When determining the permanence of plugin closure, check if the plugin has committers.

Props Ipstenu.
See #4718, #4694.

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/plugin-directory/shortcodes/class-reviews.php (modified) (1 diff)
• themes/pub/wporg-plugins/inc/template-tags.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-reviews.php

@@ -49 +49 @@
                             <div class="header-bottom">
                                 <span class="review-author author vcard"><?php the_author_posts_link(); ?></span>
-                                <span class="review-date"><?php echo date_i18n( get_option( 'date_format'), strtotime( $review->post_modified ) ); ?></span>
+                                <span class="review-date"><?php echo date_i18n( get_option( 'date_format' ), strtotime( $review->post_modified ) ); ?></span>
                             </div>
                         </header>
-                        <div class="review-content"><?php echo wp_strip_all_tags(get_the_content()); ?></div>
+                        <div class="review-content"><?php echo wp_strip_all_tags( get_the_content() ); ?></div>
                     </div>
                 </article>

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/inc/template-tags.php

@@ -224 +224 @@
 
                 // Determine permanence of closure.
-                $contributors = get_the_terms( $post, 'plugin_contributors' );
-                $permanent    = ( 'author-request' === $close_reason || ! $contributors || is_wp_error( $contributors ) );
+                $committers = Tools::get_plugin_committers( $post->post_name );
+                $permanent  = ( 'author-request' === $close_reason || ! $committers );
 
                 $days_passed = (int) ( ( current_time( 'timestamp' ) - mysql2date( 'U', $closed_date ) ) / DAY_IN_SECONDS );