Changeset 9180 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg/functions.php

Timestamp:

10/15/2019 06:53:44 AM (7 years ago)

Author:

dd32

Message:

WordPress.org, Plugin Directory, and Theme Directory: Sync the hreflang tag implementations. This prevents linking to non-existent sites.

Fixes #4713.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg/functions.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg/functions.php

@@ -238 +238 @@
         $sites = wp_cache_get( 'local-sites', 'locale-associations' );
 
+        // WARNING: for any changes below, check other uses of the `locale-assosciations` group as there's shared cache keys in use.
         if ( false === $sites ) {
                 global $wpdb;
@@ -249 +250 @@
                 require_once GLOTPRESS_LOCALES_PATH;
 
-                foreach ( $sites as $site ) {
+                foreach ( $sites as $key => $site ) {
                         $gp_locale = \GP_Locales::by_field( 'wp_locale', $site->locale );
                         if ( ! $gp_locale ) {
-                                unset( $sites[ $site->locale ] );
+                                unset( $sites[ $key ] );
                                 continue;
                         }
@@ -258 +259 @@
                         // Skip non-existing subdomains, e.g. 'de_CH_informal'.
                         if ( false !== strpos( $site->subdomain, '_' ) ) {
-                                unset( $sites[ $site->locale ] );
+                                unset( $sites[ $key ] );
                                 continue;
                         }
 
-                        if ( isset( $gp_locale->slug ) && ! in_array( $gp_locale->slug, $unsupported_languages ) ) {
-                                $sites[ $site->locale ]->hreflang = $gp_locale->slug;
+                        // Skip unsupported locales.
+                        if ( in_array( $gp_locale->slug, $unsupported_languages ) ) {
+                                unset( $sites[ $key ] );
+                                continue;
+                        }
+
+                        $hreflang = false;
+
+                        // Note that Google only supports ISO 639-1 codes.
+                        if ( isset( $gp_locale->lang_code_iso_639_1 ) && isset( $gp_locale->country_code ) ) {
+                                $hreflang = $gp_locale->lang_code_iso_639_1 . '-' . $gp_locale->country_code;
+                        } elseif ( isset( $gp_locale->lang_code_iso_639_1 ) ) {
+                                $hreflang = $gp_locale->lang_code_iso_639_1;
+                        } elseif ( isset( $gp_locale->lang_code_iso_639_2 ) ) {
+                                $hreflang = $gp_locale->lang_code_iso_639_2;
+                        } elseif ( isset( $gp_locale->lang_code_iso_639_3 ) ) {
+                                $hreflang = $gp_locale->lang_code_iso_639_3;
+                        }
+
+                        if ( $hreflang ) {
+                                $sites[ $key ]->hreflang = strtolower( $hreflang );
                         } else {
-                                unset( $sites[ $site->locale ] );
+                                unset( $sites[ $key ] );
                         }
                 }