Changeset 9182

Timestamp:

10/15/2019 07:23:53 AM (6 months ago)

Author:

dd32

Message:

SSO: Swap a bunch of login/registration redirects to 301's.

See #4630.

Location:

sites/trunk/common/includes/wporg-sso

Files:

• bb-plugin.php (modified) (2 diffs)
• wp-plugin.php (modified) (5 diffs)

sites/trunk/common/includes/wporg-sso/bb-plugin.php

@@ -35 +35 @@
                 // Redirect registration request to the one we want to standardize on.
                 if ( "https://{$this->host}{$this->script}" !== $this->sso_signup_url ) {
-                    $this->_safe_redirect( $this->sso_signup_url );
+                    $this->_safe_redirect( $this->sso_signup_url, 301 );
                 }
             } else if ( preg_match( '/\/bb-login\.php$/', $this->script ) ) {
@@ -57 +57 @@
 
                 // Redirect to SSO login, trying to pass on a decent redirect_to request.
-                $this->_safe_redirect( $redirect_to_sso_login );
+                $this->_safe_redirect( $redirect_to_sso_login, 301 );
             }
         }

sites/trunk/common/includes/wporg-sso/wp-plugin.php

@@ -169 +169 @@
             if ( preg_match( '!/wp-signup\.php$!', $this->script ) ) {
                 // If we're on any WP signup screen, redirect to the SSO host one,respecting the user's redirect_to request
-                $this->_safe_redirect( add_query_arg( 'redirect_to', urlencode( $redirect_req ), $this->sso_signup_url ) );
+                $this->_safe_redirect( add_query_arg( 'redirect_to', urlencode( $redirect_req ), $this->sso_signup_url ), 301 );
 
             } elseif ( ! $this->is_sso_host() ) {
@@ -191 +191 @@
 
                     // And actually redirect to the SSO login
-                    $this->_safe_redirect( $redirect_to_sso_login );
+                    $this->_safe_redirect( $redirect_to_sso_login, 301 );
 
                 } else {
@@ -226 +226 @@
                                     $get['redirect_to'] = $this->_get_safer_redirect_to();
                                 }
-                                $this->_safe_redirect( add_query_arg( $get, $this->sso_login_url . '/wp-login.php' ) );
+                                $this->_safe_redirect( add_query_arg( $get, $this->sso_login_url . '/wp-login.php' ), 301 );
                                 return;
                             } else {
@@ -253 +253 @@
                     } else {
                         // Otherwise, redirect to the login screen.
-                        $this->_safe_redirect( $this->sso_login_url );
+                        $this->_safe_redirect( $this->sso_login_url, 301 );
                     }
                 } else {
@@ -360 +360 @@
                 $this->_safe_redirect( $this->_get_safer_redirect_to() );
             } else {
-                $this->_safe_redirect( 'https://profiles.wordpress.org/' . wp_get_current_user()->user_nicename );
+                $this->_safe_redirect( 'https://profiles.wordpress.org/' . wp_get_current_user()->user_nicename . '/' );
             }
         }