Changeset 9188 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php

Timestamp:

10/16/2019 06:09:41 AM (7 years ago)

Author:

dd32

Message:

Theme Directory: 404 on invalid browse requests.

Fixes #4415.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php

@@ -106 +106 @@
             $query->query_vars['orderby'] = 'meta_value DESC';
             break;
+
+        default:
+            // Force a 404 for anything else.
+            if ( $query->query_vars['browse'] ) {
+                $query->query_vars['error'] = 404;
+                $query->query_vars['name'] = 'please-trigger-a-404';
+                $query->query_vars['p'] = -404;
+                $query->set_404();
+            }
+            break;
     }
 
@@ -148 +158 @@
     return $clauses;
 }
+
+/**
+ * Handle proper 404 errors for requests.
+ */
+function wporg_themes_parse_request( $wp ) {
+    $sections = array(
+        'new', 'updated', 'featured', 'favorites', 'popular'
+    );
+
+    if ( !empty( $wp->query_vars['browse'] ) && ! in_array( $wp->query_vars['browse'], $sections ) ) {
+        $wp->handle_404();
+    }
+}
+add_action( 'parse_request', 'wporg_themes_parse_request' );