Changeset 9209

Timestamp:

10/19/2019 11:15:06 AM (5 years ago)

Author:

ocean90

Message:

Translate: Update exclude list for core POT files.

• Exclude all external libraries, PHP and JavaScript.
• Exclude editor.min.js to prevent a possible parsing bug causing a memory leak (Related: ​https://github.com/wp-cli/i18n-command/issues/185).

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php

@@ -82 +82 @@
             'wp-admin/*',
             'wp-content/themes/*',
+            'wp-content/plugins/akismet/*',
+            '*.js.map', // TODO: Currently not parsable, https://wordpress.slack.com/archives/C02RP4T41/p1541003227208000.
+            // External libraries.
+            'wp-includes/ID3/*',
+            'wp-includes/IXR/*',
+            'wp-includes/pomo/*',
+            'wp-includes/random_compat/*',
+            'wp-includes/Requests/*',
+            'wp-includes/SimplePie/*',
+            'wp-includes/Text/*',
+            'wp-includes/sodium_compat/*',
+            'wp-includes/atomlib.php',
+            'wp-includes/class-IXR.php',
+            'wp-includes/class-json.php',
+            'wp-includes/class-phpass.php',
+            'wp-includes/class-phpmailer.php',
             'wp-includes/class-pop3.php',
-            'wp-content/plugins/akismet/*',
-            // External JavaScript libaries.
+            'wp-includes/class-requests.php',
+            'wp-includes/class-simplepie.php',
+            'wp-includes/class-smtp.php',
+            'wp-includes/class-snoopy.php',
+            'wp-includes/rss.php',
             'wp-includes/js/codemirror/*',
             'wp-includes/js/crop/*',
@@ -95 +114 @@
             'wp-includes/js/thickbox/*',
             'wp-includes/js/tw-sack.js',
-            '*.js.map', // TODO: Currently not parsable, https://wordpress.slack.com/archives/C02RP4T41/p1541003227208000.
         ];
 
@@ -150 +168 @@
         }
 
+        $admin_exclude = [
+            'wp-admin/includes/continents-cities.php',
+            'editor.min.js', // Explicitly excluded as it's causing a memory leak: https://github.com/wp-cli/i18n-command/issues/185
+            // External libraries.
+            'wp-admin/includes/class-ftp*',
+            'wp-admin/includes/class-pclzip.php',
+        ];
+
+        $admin_exclude = array_merge( $admin_exclude, $admin_network_files );
+
         $command  = 'i18n make-pot ' . escapeshellarg( $this->source );
         $command .= ' ' . escapeshellarg( $this->destination . '/wordpress-admin.pot' );
-        $command .= ' --exclude=' . escapeshellarg( implode( ',', array_merge( [ 'wp-admin/includes/continents-cities.php' ], $admin_network_files ) ) );
+        $command .= ' --exclude=' . escapeshellarg( implode( ',', $admin_exclude ) );
         $command .= ' --include="wp-admin/*"';
         $command .= ' --merge=' . escapeshellarg( $hello_dolly_pot );