Changeset 9230 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client/components/plugin-icon/index.jsx

Timestamp:

10/24/2019 06:54:36 AM (7 years ago)

Author:

dd32

Message:

Plugin Directory: Fix some HTML validation errors.

• Remove duplicate ID's
• Don't nest <style> under <a>

See #4730.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client/components/plugin-icon/index.jsx (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client/components/plugin-icon/index.jsx

@@ -34 +34 @@
         return (
                 <div className="entry-thumbnail">
-                        <div className="plugin-icon" id={ `plugin-icon-${ slug }` } />
+                        <div className="{ `plugin-icon plugin-icon-${ slug }` }" />
                         <style type="text/css">
-                                { `#plugin-icon-${ slug } { background-image: url('${ icon }'); }` }
+                                { `.plugin-icon-${ slug } { background-image: url('${ icon }'); }` }
                                 { icons[ '2x' ] && icon !== icons.default
                                         // eslint-disable-next-line max-len
-                                        ? `@media only screen and (-webkit-min-device-pixel-ratio: 1.5), only screen and (min-resolution: 144dpi) { #plugin-icon-${ slug } { background-image: url('${ icons[ '2x' ] }'); } }`
+                                        ? `@media only screen and (-webkit-min-device-pixel-ratio: 1.5), only screen and (min-resolution: 144dpi) { .plugin-icon-${ slug } { background-image: url('${ icons[ '2x' ] }'); } }`
                                         : ''
                                 }