Changeset 9237 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-author-card.php

Timestamp:

10/25/2019 03:02:29 AM (5 years ago)

Author:

dd32

Message:

Plugin Directory: Author Card: Only query for plugins if there are plugins. Avoids a 'bad looking' query with an empty IN()

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-author-card.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-author-card.php

@@ -97 +97 @@
         }
         $author_plugins = get_posts( $author_plugins_q );
-        $all_plugins    = $wpdb->get_results( "SELECT * FROM {$wpdb->posts} WHERE post_name IN ('" . implode( "', '", array_merge( $author_commit, wp_list_pluck( $author_plugins, 'post_name' ) ) ) . "')" );
+        $all_plugins    = array();
+        if ( $author_plugins || $author_commit ) {
+            $all_plugins = $wpdb->get_results( "SELECT * FROM {$wpdb->posts} WHERE post_name IN ('" . implode( "', '", array_merge( $author_commit, wp_list_pluck( $author_plugins, 'post_name' ) ) ) . "')" );
+        }
         ?>
         <div class="profile">