Changeset 9255

Timestamp:

11/03/2019 05:22:28 PM (6 years ago)

Author:

dd32

Message:

Plugin Directory: Add a warning/block to the plugin upload screen to prevent users with "unsafe" email addresses from submitting plugins.

"unsafe" emails on WordPress.org include domains we consider spam and those who reject all emails from us. As these users can't receive emails, we can't allow them to upload a plugin until they change to an email host which does accept our emails.

Fixes #4781.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload.php

@@ -166 +166 @@
             <?php endif; // wp_verify_nonce() && 'upload' === $_POST['action'] ?>
 
-            <?php if ( ! $submitted_counts->total && ( ! $upload_result || is_wp_error( $upload_result ) ) ) : ?>
+            <?php
+            if ( is_email_address_unsafe( wp_get_current_user()->user_email ) ) {
+                echo '<div class="notice notice-error notice-alt"><p>' .
+                    sprintf(
+                        /* translators: %s: Profile edit url. */
+                        __( 'Your email host has email deliverability problems. Please <a href="%s">Update your email address</a> first.', 'wporg-plugins'),
+                        esc_url( 'https://wordpress.org/support/users/' . wp_get_current_user()->user_nicename . '/edit' )
+                     ) .
+                     "</p></div>\n";
+
+            } else if ( ! $submitted_counts->total && ( ! $upload_result || is_wp_error( $upload_result ) ) ) : ?>
 
                 <form id="upload_form" class="plugin-upload-form" enctype="multipart/form-data" method="POST" action="">