Changeset 9284

Timestamp:

11/20/2019 06:59:20 AM (5 years ago)

Author:

dd32

Message:

Plugin Directory: Cron Jobs: Clear the Memcache cache within WordPress after processing lots of posts to allow Jetpack Sync to have some memory free.

This avoids plenty of post-shutdown fatals in cron tasks WordPress.org is currently experiencing and consolidates such code to a single instance.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs

Files:

• class-manager.php (modified) (1 diff)
• class-meta-sync.php (modified) (3 diffs)
• class-plugin-support-resolved.php (modified) (1 diff)
• class-translation-sync.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-manager.php

@@ -310 +310 @@
     }
 
+    /**
+     * Clear caches for memory management.
+     *
+     * @static
+     * @global \wpdb            $wpdb
+     * @global \WP_Object_Cache $wp_object_cache
+     */
+    public static function clear_memory_heavy_variables() {
+        global $wpdb, $wp_object_cache;
+
+        $wpdb->queries = [];
+
+        if ( is_object( $wp_object_cache ) ) {
+            $wp_object_cache->cache          = [];
+            $wp_object_cache->group_ops      = [];
+            $wp_object_cache->memcache_debug = [];
+        }
+    }
 
 }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php

@@ -26 +26 @@
         $this->sync_ratings();
         $this->update_tested_up_to();
+
+        Manager::clear_memory_heavy_variables();
     }
 
@@ -167 +169 @@
         $tested_values             = $wpdb->get_results( "SELECT post_id, post_name, meta_value FROM {$wpdb->postmeta} pm JOIN {$wpdb->posts} p ON pm.post_id = p.ID WHERE meta_key = 'tested' AND meta_value IN( {$tested_meta_value_esc_sql} )" );
 
-        foreach ( $tested_values as $row ) {
+        foreach ( $tested_values as $i => $row ) {
             update_post_meta(
                 $row->post_id,
@@ -176 +178 @@
             // Update the API endpoints with the new data
             API_Update_Updater::update_single_plugin( $row->post_name );
+
+            if ( $i % 100 === 0 ) {
+                Manager::clear_memory_heavy_variables();
+            }
         }
     }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-plugin-support-resolved.php

@@ -70 +70 @@
             }
 
-            self::stop_the_insanity();
+            Manager::clear_memory_heavy_variables();
         }
     }
 
-    /**
-     * Clear caches for memory management.
-     *
-     * @static
-     * @global \wpdb            $wpdb
-     * @global \WP_Object_Cache $wp_object_cache
-     */
-    protected static function stop_the_insanity() {
-        global $wpdb, $wp_object_cache;
-
-        $wpdb->queries = [];
-
-        if ( is_object( $wp_object_cache ) ) {
-            $wp_object_cache->cache          = [];
-            $wp_object_cache->group_ops      = [];
-            $wp_object_cache->memcache_debug = [];
-            $wp_object_cache->stats          = [];
-        }
-    }
 }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-translation-sync.php

@@ -30 +30 @@
 
             // Make sure the cache doesn't exhaust memory
-            global $wp_object_cache;
-            if ( is_object( $wp_object_cache ) ) {
-                $wp_object_cache->cache = array();
-                $wp_object_cache->stats = array( 'add' => 0, 'get' => 0, 'get_multi' => 0, 'delete' => 0);
-                $wp_object_cache->group_ops = array();
-            }
+            Manager::clear_memory_heavy_variables();
 
             $args['offset'] += $args['posts_per_page'];