Changeset 9303

Timestamp:

11/28/2019 02:19:33 AM (4 years ago)

Author:

dd32

Message:

Theme Directory: Add some guard clauses to prevent PHP Notices in Meta Development environments where the full data is not available.

Props dingo_d.
Fixes #4858.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-repo-package.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-repo-package.php

@@ -38 +38 @@
     public function latest_version() {
         $status = get_post_meta( $this->wp_post->ID, '_status', true );
+
+        if ( empty( $status ) ) {
+            return '';
+        }
+
         uksort( $status, 'version_compare' );
 
@@ -64 +69 @@
                 return $version;
             case 'theme-url' :
-                return $this->wp_post->_theme_url[ $version ];
+                return $this->wp_post->_theme_url[ $version ] ?? '';
             case 'author-url' :
-                return $this->wp_post->_author_url[ $version ];
+                return $this->wp_post->_author_url[ $version ] ?? '';
             case 'ticket' :
-                return $this->wp_post->_ticket_id[ $version ];
+                return $this->wp_post->_ticket_id[ $version ] ?? '';
             case 'requires':
                 $values = $this->wp_post->_requires;