Changeset 9372

Timestamp:

12/20/2019 08:32:47 AM (5 years ago)

Author:

dd32

Message:

Trac: Github PRs: Add a wrapper for the Trac class for easier testing.

See #4903.

Location:

sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr

Files:

• functions.php (modified) (1 diff)
• webhook.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/functions.php

@@ -144 +144 @@
 }
 
+/**
+ * Returns a instance of the Trac class for a given trac.
+ */
+function get_trac_instance( $trac ) {
+    $trac_uri = 'https://' . $trac . '.trac.wordpress.org/login/rpc';
+
+    return new Trac( GH_PRBOT_USER, GH_PRBOT_PASS, $trac_uri );
+}

sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/webhook.php

@@ -77 +77 @@
 
             // Add a mention to the Trac Ticket.
-            $trac_uri = 'https://' . $pr_data->trac_ticket[0] . '.trac.wordpress.org/login/rpc';
-            $trac = new Trac( GH_PRBOT_USER, GH_PRBOT_PASS, $trac_uri );
+            $trac = get_trac_instance( $pr_data->trac_ticket[0] );
 
             $trac->update(