Changeset 9391

Timestamp:

01/11/2020 01:38:37 AM (6 years ago)

Author:

coffee2code

Message:

Developer: Refactor dynamic min-height calculation for preview tab.

Now at minimum it has the same height as the write tab, preventing drastic tab size differences with short input text. Also now fires on tab view.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/user-notes-preview.js (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/user-notes-preview.js

@@ -6 +6 @@
 ( function( $ ) {
 
-    var textarea, textareaHeight, text, preview, previewContent, tabs, processing, spinner;
+    var textarea, tabContentHeight, text, preview, previewContent, tabs, processing, spinner;
 
     function init() {
@@ -46 +46 @@
         tabs.on( "keydown.note_preview, click.note_preview", function( e ) {
 
+            // Preview tab should be at least as tall input tab to prevent resizing wonkiness.
+            tabContentHeight = $( '#comment-form-comment' ).outerHeight( false );
+
+            if ( 0 < tabContentHeight ) {
+                preview.css( 'min-height', tabContentHeight + 'px' );
+            }
+
             if ( 'comment-preview' === $( this ).attr( 'aria-controls' ) ) {
 
@@ -69 +76 @@
                 textarea.focus();
             }
-        } );
-
-        // Set preview heigth when the textarea is visible
-        $( '.table-of-contents a[href="#add-note-or-feedback"]' ).click( function( e ) {
-            e.preventDefault();
-            tabs.parents( '.tablist' ).show();
-            setTimeout( function() {
-                textareaHeight = textarea.outerHeight( true );
-                if ( 0 < textareaHeight ) {
-                    preview.css( 'min-height', textareaHeight + 'px' );
-                }
-            }, 500 );
         } );
     }