Changeset 9446

Timestamp:

01/31/2020 12:16:37 AM (5 years ago)

Author:

coffee2code

Message:

Browse Happy API: Consider all versions of Internet Explorer as insecure.

Props youknowriad, coffee2code.
Fixes #4863.

Location:

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0

Files:

• parse.php (modified) (1 diff)
• tests/phpunit/tests/browse-happy.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/parse.php

@@ -364 +364 @@
     $data['upgrade']         = ( ! empty( $data['current_version'] ) && version_compare( $data['version'], $data['current_version'], '<' ) );
 
-    if ( 'Internet Explorer' === $data['name'] && version_compare( $data['version'], '11', '<' ) ) {
+    if ( 'Internet Explorer' === $data['name'] ) {
         $data['insecure'] = true;
+        $data['upgrade']  = true;
     } elseif ( 'Firefox' === $data['name'] && version_compare( $data['version'], '52', '<' ) ) {
         $data['insecure'] = true;

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/tests/phpunit/tests/browse-happy.php

@@ -825 +825 @@
         $parsed = browsehappy_parse_user_agent( $header );
 
-        if ( 'Internet Explorer' === $parsed['name'] && version_compare( $parsed['version'], '11', '<' ) ) {
+        if ( 'Internet Explorer' === $parsed['name'] ) {
             $this->assertTrue( $parsed['insecure'] );
         } elseif ( 'Firefox' === $parsed['name'] && version_compare( $parsed['version'], '52', '<' ) ) {