Changeset 9506 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

Timestamp:

02/14/2020 05:08:35 AM (5 years ago)

Author:

dd32

Message:

Plugin Directory: Skip outdated plugins from being included in the Jetpack Sitemaps.

This may cause OOM fatals due to the usage of get_post() in Template::is_plugin_outdated() which may exhaust the in-memory object-cache cache.

Fixes #5025.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -41 +41 @@
         add_filter( 'pre_update_option_jetpack_options', array( $this, 'filter_jetpack_options' ) );
         add_filter( 'jetpack_sitemap_post_types', array( $this, 'jetpack_sitemap_post_types' ) );
+        add_filter( 'jetpack_sitemap_skip_post', array( $this, 'jetpack_sitemap_skip_post' ), 10, 2 );
         add_action( 'template_redirect', array( $this, 'prevent_canonical_for_plugins' ), 9 );
         add_action( 'template_redirect', array( $this, 'custom_redirects' ), 1 );
@@ -1374 +1375 @@
 
         return $post_types;
+    }
+
+    /**
+     * Skip outdated plugins in Jetpack Sitemaps.
+     * 
+     * @param bool $skip If this post should be excluded from Sitemaps.
+     * @param object $plugin_db_row A row from the wp_posts table.
+     * @return bool
+     */
+    public function jetpack_sitemap_skip_post( $skip, $plugin_db_row ) {
+        if ( Template::is_plugin_outdated( $plugin_db_row->ID ) ) {
+            $skip = true;
+        }
+
+        return $skip;
     }