Changeset 9512

Timestamp:

02/19/2020 05:09:16 AM (7 years ago)

Author:

dd32

Message:

Trac: Actually show the Github PR section for unauthenticated users, the element this was attached to previously relied upon the current user being able to upload a patch, or another user having already done so.

See [9510], #4903.

File:

• sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -1599 +1599 @@
 
                         function renderAddSection() {
-                                // Add the Pull Requests section.
-                                $( '#attachments' ).append(
+                                // Add the Pull Requests section, #attachments is only present if authenticated or there exists uploads.
+                                var afterDiv = $( '#attachments' );
+                                if ( ! afterDiv.length ) {
+                                        afterDiv = $( '#commits' );
+                                }
+
+                                afterDiv.after(
                                         '<div id="github-prs">' +
                                                 '<h3 class="foldable"><a id="section-pr" href="#section-pr">Pull Requests <span class="trac-count hidden">(<span></span>)</span></a></h3>' +