Changeset 9524

Timestamp:

02/21/2020 01:37:06 AM (6 years ago)

Author:

dd32

Message:

Theme Directory: Add some debugging to try to figure out the cause of none, or 1 theme only showing up on the Theme Directory homepage.

See #3215.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-themes-api.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-themes-api.php

@@ -450 +450 @@
                 $cache_key = sanitize_key( __METHOD__ . ':' . get_locale() . ':' . md5( serialize( $this->request ) . serialize( $this->fields ) ) );
                 if ( false !== ( $this->response = wp_cache_get( $cache_key, $this->cache_group ) ) && empty( $this->request->cache_buster ) ) {
-                        return;
+
+                        // DEBUG - Attempt to skip the cache when it only contains one theme when it should contain many.
+                        if (
+                                isset( $this->request->browse ) &&
+                                'popular' === $this->request->browse &&
+                                $this->response->info['results'] <= 1
+                        ) {
+                                // The cache is bad. Don't use it.
+                                $this->response = false;
+                        } else {
+                                // The cache is good, use it.
+                                return;
+                        }
                 }
 
@@ -461 +473 @@
                 if ( empty( $this->request->fields ) ) {
                         $this->request->fields = array();
-                }
-
-                // DEBUG
-                if ( function_exists( 'slack_dm' ) && isset( $wp_query->query_vars['browse'] ) && 'featured' === $wp_query->query_vars['browse'] && 1 === $this->result->found_posts ) {
-                        slack_dm( print_r( $this->request, 1 ), 'obenland' );
-                        slack_dm( print_r( $wp_query, 1 ), 'obenland' );
                 }
 
@@ -485 +491 @@
                 foreach ( (array) $this->result->posts as $theme ) {
                         $this->response->themes[] = $this->fill_theme( $theme );
+                }
+
+                // DEBUG - Try to find out why the cache for the popular/featured views occasionally only include 1 theme.
+                if (
+                        function_exists( 'slack_dm' ) &&
+                        ( 1 === $this->response->info['results'] || 0 === $this->response->info['results'] ) &&
+                        isset( $this->request->browse ) &&
+                        'popular' === $this->request->browse
+                ) {
+                        slack_dm( $_SERVER['REQUEST_URI'], 'dd32' );
+                        slack_dm( print_r( $this->request, 1 ), 'dd32' );
+                        slack_dm( print_r( $wp_query, 1 ), 'dd32' );
                 }