Changeset 9616 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/class-plugin.php

Timestamp:

03/22/2020 12:05:56 PM (5 years ago)

Author:

ocean90

Message:

Translate: Remove cron schedules for cache updates, update data on the fly.

Prevents missing data before the next schedule is run.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/class-plugin.php (modified) (8 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/class-plugin.php

@@ -9 +9 @@
 class Plugin {
 
+    public const CACHE_GROUP = 'wporg-translate';
+
     /**
      * @var Plugin The singleton instance.
@@ -44 +46 @@
         add_filter( 'gp_locale_glossary_path_prefix', [ $this, 'set_locale_glossary_path_prefix' ] );
 
-        add_filter( 'cron_schedules', [ $this, 'register_cron_schedules' ] );
-        add_action( 'init', [ $this, 'register_cron_events' ] );
         add_action( 'init', [ $this, 'respect_robots_txt' ], 9 );
-        add_action( 'wporg_translate_update_existing_locales_cache', [ $this, 'update_existing_locales_cache' ] );
-        add_action( 'wporg_translate_update_translation_status_cache', [ $this, 'update_translation_status_cache' ] );
-        add_action( 'wporg_translate_update_contributors_count_cache', [ $this, 'update_contributors_count_cache' ] );
     }
 
@@ -180 +177 @@
 
     /**
-     * Filters the non-default cron schedules.
-     *
-     * @param array $schedules An array of non-default cron schedules.
-     * @return array  An array of non-default cron schedules.
-     */
-    public function register_cron_schedules( $schedules ) {
-        $schedules['15_minutes'] = array(
-            'interval' => 15 * MINUTE_IN_SECONDS,
-            'display'  => 'Every 15 minutes',
-        );
-
-        return $schedules;
-    }
-
-    /**
-     * Registers CLI commands if WP-CLI is loaded.
-     */
-    public function register_cron_events() {
-        if ( ! wp_next_scheduled( 'wporg_translate_update_existing_locales_cache' ) ) {
-            wp_schedule_event( time(), '15_minutes', 'wporg_translate_update_existing_locales_cache' );
-        }
-
-        if ( ! wp_next_scheduled( 'wporg_translate_update_translation_status_cache' ) ) {
-            wp_schedule_event( time() + 3 * MINUTE_IN_SECONDS, '15_minutes', 'wporg_translate_update_translation_status_cache' );
-        }
-
-        if ( ! wp_next_scheduled( 'wporg_translate_update_contributors_count_cache' ) ) {
-            wp_schedule_event( time() + 6 * MINUTE_IN_SECONDS, '15_minutes', 'wporg_translate_update_contributors_count_cache' );
-        }
-    }
-
-    /**
      * Calculates the translation status of the WordPress project per locale.
      */
-    public function update_translation_status_cache() {
+    public static function get_translation_status() {
         global $wpdb;
 
         if ( ! isset( $wpdb->project_translation_status ) ) {
             return;
+        }
+
+        $cached = wp_cache_get( 'translation-status', self::CACHE_GROUP );
+        if ( false !== $cached ) {
+            return $cached;
         }
 
@@ -229 +199 @@
         ), OBJECT_K );
 
-        if ( ! $translation_status ) {
-            return;
-        }
-
-        wp_cache_set( 'translation-status', $translation_status, 'wporg-translate' );
+        wp_cache_set( 'translation-status', $translation_status, 'wporg-translate', 15 * MINUTE_IN_SECONDS );
+
+        return $translation_status;
     }
 
@@ -239 +207 @@
      * Updates contributors count per locale.
      */
-    public function update_contributors_count_cache() {
+    public static function get_contributors_count() {
         global $wpdb;
 
+        $cached = wp_cache_get( 'contributors-count', self::CACHE_GROUP );
+        if ( false !== $cached ) {
+            return $cached;
+        }
+
         if ( ! isset( $wpdb->user_translations_count ) ) {
-            return;
-        }
-
-        $locales   = $this->get_existing_locales();
+            return [];
+        }
+
+        $locales   = self::get_existing_locales();
         $db_counts = $wpdb->get_results(
             "SELECT `locale`, COUNT( DISTINCT user_id ) as `count` FROM {$wpdb->user_translations_count} WHERE `accepted` > 0 GROUP BY `locale`",
             OBJECT_K
         );
-
-        if ( ! $db_counts || ! $locales ) {
-            return;
-        }
 
         $counts = array();
@@ -265 +234 @@
         }
 
-        wp_cache_set( 'contributors-count', $counts, 'wporg-translate' );
+        wp_cache_set( 'contributors-count', $counts, self::CACHE_GROUP, 15 * MINUTE_IN_SECONDS );
+
+        return $counts;
     }
 
@@ -276 +247 @@
      * @return array List of GlotPress locales.
      */
-    private function get_existing_locales() {
+    public static function get_existing_locales() {
         global $wpdb;
 
-        return $wpdb->get_col(
+        $cached = wp_cache_get( 'existing-locales', self::CACHE_GROUP );
+        if ( false !== $cached ) {
+            return $cached;
+        }
+
+        $existing_locales = $wpdb->get_col(
             $wpdb->prepare(
                 "SELECT locale FROM {$wpdb->gp_translation_sets} WHERE `project_id` = %d and slug = %s",
@@ -286 +262 @@
             )
         );
-    }
-
-    /**
-     * Updates cache for existing locales.
-     */
-    public function update_existing_locales_cache() {
-        $existing_locales = $this->get_existing_locales();
-        if ( ! $existing_locales ) {
-            return;
-        }
-
-        wp_cache_set( 'existing-locales', $existing_locales, 'wporg-translate' );
+
+        wp_cache_set( 'existing-locales', $existing_locales, self::CACHE_GROUP, HOUR_IN_SECONDS );
+
+        return $existing_locales;
     }
 }