Changeset 9668 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-locale-banner.php

Timestamp:

04/01/2020 03:03:01 AM (6 years ago)

Author:

dd32

Message:

Plugin Directory: Switch the locale banner to a GET request and cache the request for up-to 1 hour.

See #3604.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-locale-banner.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-locale-banner.php

@@ -14 +14 @@
         function __construct() {
                 register_rest_route( 'plugins/v1', '/locale-banner', array(
-                        'methods'  => WP_REST_Server::EDITABLE,
+                        'methods'  => WP_REST_Server::ALLMETHODS,
                         'callback' => array( $this, 'locale_banner' ),
                         'args'     => array(
@@ -210 +210 @@
                 }
 
-                $result = [
+                $result = new \WP_REST_Response( [
                         'suggest_string' => $suggest_string,
                         'translated'     => $translated_locales,
-                ];
+                ] );
+
+                // Allow this API to be cached, varied by Accept-Language header.
+                $result->header( 'Vary', 'Accept-Language' );
+                $result->header( 'Expires', gmdate( 'r', time() + 3600 ) );
+                $result->header( 'Cache-Control', 'max-age=3600' );
 
                 return $result;