Changeset 9707

Timestamp:

04/07/2020 01:30:02 AM (4 years ago)

Author:

dd32

Message:

Plugin Directory: Require confirmation before transferring and closing a plugin.

This also requires specifically selecting a new owner of the plugin.

See #5131, #1560.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/inc/template-tags.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/inc/template-tags.php

@@ -331 +331 @@
 
     if ( $close_link ) {
-        echo '<form method="POST" action="' . esc_url( $close_link ) . '">';
+        echo '<form method="POST" action="' . esc_url( $close_link ) . '" onsubmit="return confirm( jQuery(this).prev(\'.notice\').text() );">';
         // Translators: %s is the plugin name, as defined by the plugin itself.
         echo '<p><input class="button" type="submit" value="' . esc_attr( sprintf( __( 'I understand, please close %s.', 'wporg-plugins' ), get_the_title() ) ) . '" /></p>';
@@ -380 +380 @@
     }
 
-    echo '<form method="POST" action="' . esc_url( Template::get_self_transfer_link() ) . '">';
+    echo '<form method="POST" action="' . esc_url( Template::get_self_transfer_link() ) . '" onsubmit="return ( 0 != document.getElementById(\'transfer-new-owner\').value ) && confirm( jQuery(this).prev(\'.notice\').text() );">';
     echo '<p><label for="new_owner">' . esc_html__( 'New Owner', 'wporg-plugins' ) . '</label><br>';
-    echo '<select name="new_owner">';
+    echo '<select id="transfer-new-owner" name="new_owner">';
+    echo '<option value="0">---</option>';
     foreach ( $users as $user ) {
         printf(