Changeset 9721

Timestamp:

04/14/2020 05:41:30 PM (6 years ago)

Author:

ocean90

Message:

Translate: Skip threshold check for building language packs for plugins/themes with an existing language pack.

Also, reduce initial threshold to 90%.

See ​https://make.wordpress.org/polyglots/?p=28345.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-language-pack.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-language-pack.php

@@ -16 +16 @@
         const BUILD_DIR = '/nfs/rosetta/builds';
         const SVN_URL = 'https://i18n.svn.wordpress.org';
-        const PACKAGE_THRESHOLD = 95;
+        const PACKAGE_THRESHOLD = 90;
 
         /**
@@ -320 +320 @@
 
         /**
-         * Retrieves activate language packs for a theme/plugin of a version.
+         * Retrieves active language packs for a theme/plugin of a version.
          *
          * @param string $type    Type of the language pack. Supports 'plugin' or 'theme'.
@@ -342 +342 @@
 
                 return $active_language_packs;
+        }
+
+        /**
+         * Whether there's at least one active language pack for a theme/plugin of any version.
+         *
+         * @param string $type   Type of the language pack. Supports 'plugin' or 'theme'.
+         * @param string $domain Slug of a theme/plugin.
+         * @param string $locale WordPress locale.
+         * @return boolean True if theme/plugin has an active language pack, false if not.
+         */
+        private function has_active_language_pack( $type, $domain, $locale ) {
+                global $wpdb;
+
+                return (bool) $wpdb->get_var( $wpdb->prepare(
+                        'SELECT updated FROM language_packs WHERE type = %s AND domain = %s AND language = %s AND active = 1 LIMIT 1',
+                        $type,
+                        $domain,
+                        $locale
+                ) );
         }
 
@@ -588 +607 @@
                         }
 
-                        // Check if percent translated is above threshold.
-                        $percent_translated = $set->percent_translated();
-                        if ( ! $this->force && $percent_translated < self::PACKAGE_THRESHOLD ) {
-                                WP_CLI::log( "Skip {$wp_locale}, translations below threshold ({$percent_translated}%)." );
-                                continue;
+                        // Check if percent translated is above threshold for initial language pack.
+                        $has_existing_pack = $this->has_active_language_pack( $data->type, $data->domain, $wp_locale );
+                        if ( ! $has_existing_pack ) {
+                                $percent_translated = $set->percent_translated();
+                                if ( ! $this->force && $percent_translated < self::PACKAGE_THRESHOLD ) {
+                                        WP_CLI::log( "Skip {$wp_locale}, translations below threshold ({$percent_translated}%)." );
+                                        continue;
+                                }
+                        } else {
+                                WP_CLI::log( "Skipping threshold check for {$wp_locale}, has existing language pack." );
                         }