Changeset 9848

Timestamp:

05/12/2020 04:56:02 AM (5 years ago)

Author:

dd32

Message:

Support Forums: Use the actual date as the title text for date links.

Fixes #5121.

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/support-forums/inc/class-hooks.php (modified) (2 diffs)
• themes/pub/wporg-support/bbpress/content-single-topic-lead.php (modified) (1 diff)
• themes/pub/wporg-support/bbpress/loop-single-reply.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php

@@ -121 +121 @@
         add_filter( 'bbp_edit_topic_pre_content', array( $this, 'support_slack_trac_code_trick' ),  19 );
         add_filter( 'bbp_edit_forum_pre_content', array( $this, 'support_slack_trac_code_trick' ),  19 );
+
+        // Freshness links should have the datetime as a title rather than the thread title.
+        add_filter( 'bbp_get_topic_freshness_link', array( $this, 'bbp_get_topic_freshness_link' ), 10, 5 );
+
     }
 
@@ -1178 +1182 @@
         return $content;
     }
+    
+    /**
+     * Alter the bbPress topic freshness links to use the date in the title attribute rather than thread title.
+     */
+    function bbp_get_topic_freshness_link( $anchor, $topic_id, $time_since, $link_url, $title ) {
+
+        // Copy-paste from bbp_get_topic_last_active_time() which only returns humanized times.
+        // Try to get the most accurate freshness time possible
+        $last_active = get_post_meta( $topic_id, '_bbp_last_active_time', true );
+        if ( empty( $last_active ) ) {
+            if ( ! empty( $reply_id ) ) {
+                $last_active = get_post_field( 'post_date', $reply_id );
+            } else {
+                $last_active = get_post_field( 'post_date', $topic_id );
+            }
+        }
+
+        // This is for translating the date components.
+        $datetime = date_create_immutable_from_format( 'Y-m-d H:i:s', $last_active );
+        $date     = wp_date( get_option( 'date_format' ), $datetime->getTimestamp() );
+        $time     = wp_date( get_option( 'time_format' ), $datetime->getTimestamp() );
+
+        return str_replace(
+            'title="' . esc_attr( $title ) . '"',
+            'title="' . esc_attr(
+                // bbPress string from bbp_get_reply_post_date()
+                sprintf( _x( '%1$s at %2$s', 'date at time', 'wporg-support' ), $date, $time )
+            ) . '"',
+            $anchor
+        );
+    }
 }

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/bbpress/content-single-topic-lead.php

@@ -59 +59 @@
                 <?php endif; ?>
 
-                <p class="bbp-topic-post-date"><a href="<?php bbp_topic_permalink(); ?>" title="#<?php bbp_topic_id(); ?>" class="bbp-topic-permalink"><?php bbp_topic_post_date( bbp_get_topic_id(), true ); ?></a></p>
+                <p class="bbp-topic-post-date"><a href="<?php bbp_topic_permalink(); ?>" title="<?php echo esc_attr( bbp_get_topic_post_date( bbp_get_topic_id() ) ); ?>" class="bbp-topic-permalink"><?php bbp_topic_post_date( bbp_get_topic_id(), true ); ?></a></p>
 
                 <?php if ( current_user_can( 'moderate', bbp_get_topic_id() ) ) : ?>

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/bbpress/loop-single-reply.php

@@ -46 +46 @@
         <div class="bbp-reply-meta">
 
-        <p class="bbp-reply-post-date"><a href="<?php bbp_reply_url(); ?>" title="#<?php bbp_reply_id(); ?>" class="bbp-reply-permalink"><?php bbp_reply_post_date( bbp_get_reply_id(), true ); ?></a></p>
+        <p class="bbp-reply-post-date"><a href="<?php bbp_reply_url(); ?>" title="<?php echo esc_attr( bbp_get_reply_post_date( bbp_get_reply_id() ) ); ?>" class="bbp-reply-permalink"><?php bbp_reply_post_date( bbp_get_reply_id(), true ); ?></a></p>
 
         <?php if ( current_user_can( 'moderate', bbp_get_reply_topic_id() ) ) : ?>