Changeset 9850

Timestamp:

05/12/2020 05:46:00 AM (6 years ago)

Author:

dd32

Message:

Support Forums: Canonical: Don't redirect bbPress root page parents to random topics.
Examples: /users/ /topics/ and /reply

Fixes #4606.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php

@@ -16 +16 @@
                 add_filter( 'bbp_map_meta_caps',               array( $this, 'disallow_editing_past_lock_time' ), 10, 4 );
                 add_filter( 'redirect_canonical',              array( $this, 'disable_redirect_guess_404_permalink' ) );
+                add_filter( 'redirect_canonical',              array( $this, 'handle_bbpress_root_pages' ), 10, 2 );
                 add_filter( 'old_slug_redirect_post_id',       array( $this, 'disable_wp_old_slug_redirect' ) );
                 add_action( 'template_redirect',               array( $this, 'redirect_update_php_page' ) );
@@ -241 +242 @@
                 // Avoid redirecting the old slug of "Update PHP" page to a forum topic.
                 if ( is_404() && 'upgrade-php' === get_query_var( 'pagename' ) ) {
+                        $redirect_url = false;
+                }
+
+                return $redirect_url;
+        }
+
+        /**
+         * Prevent a redirect for some base bbPress pages to random topics.
+         */
+        public function handle_bbpress_root_pages( $redirect_url, $requested_url ) {
+                $url = str_replace( home_url('/'), '', $requested_url );
+
+                if ( $url && preg_match( '!^(topic|topic-[^/]+|reply|users|view)(/[?]|/?$)!i', $url ) ) {
                         $redirect_url = false;
                 }
@@ -1186 +1200 @@
          * Alter the bbPress topic freshness links to use the date in the title attribute rather than thread title.
          */
-        function bbp_get_topic_freshness_link( $anchor, $topic_id, $time_since, $link_url, $title ) {
+        public function bbp_get_topic_freshness_link( $anchor, $topic_id, $time_since, $link_url, $title ) {
 
                 // Copy-paste from bbp_get_topic_last_active_time() which only returns humanized times.