Changeset 9872

Timestamp:

05/13/2020 06:55:56 AM (4 years ago)

Author:

dd32

Message:

SEO: Canonical: Only include the order param if it's a valid sort value.

See #5173, #5169.

File:

• sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-seo/canonical.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-seo/canonical.php

@@ -150 +150 @@
     if ( is_archive() || is_search() || is_home() ) {
         // Check $wp since `get_query_var()` will return default values too.
-        if ( !empty( $wp->query_vars[ 'order'] ) ) {
+        if ( !empty( $wp->query_vars[ 'order'] ) && in_array( $wp->query_vars[ 'order'], [ 'asc', 'desc' ], true ) ) {
             $url = add_query_arg( 'order', get_query_var( 'order' ), $url );
         }