Changeset 9886

Timestamp:

05/19/2020 04:03:10 PM (5 years ago)

Author:

Otto42

Message:

Plugins: rm temp fix, add upload_size_limit filter to limit uploads of ZIP files for review to 10M across the board, instead of relying on individual network settings.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• class-plugin-directory.php (modified) (1 diff)
• shortcodes/class-upload.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -60 +60 @@
         // Cron tasks.
         new Jobs\Manager();
+
+        // Add upload size limit to limit plugin ZIP file uploads to 10M
+        add_filter( 'upload_size_limit', function( $size ) {
+            return 10 * MB_IN_BYTES;
+        } );
 
         // oEmbed whitlisting.

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload.php

@@ -259 +259 @@
         $upload_size_unit = wp_max_upload_size();
 
-        // force max to 10M, since some sites seem to incorrectly report different values (temporary fix during investigation)
-        if ( $upload_size_unit > 10485760 ) {
-            $upload_size_unit = 10485760;
-        }
-            
         $byte_sizes       = array( 'KB', 'MB', 'GB' );