WordPress.org

Making WordPress.org

Changeset 9912


Ignore:
Timestamp:
05/25/2020 01:42:44 AM (19 months ago)
Author:
dd32
Message:

Trac: Handle PRs with no code reviews better.

Amends [9898].
See #5052.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

    r9898 r9912  
    17121712                        break;
    17131713                    case 'blocked':
    1714                         // All Good, Changes Requested, or unit tests failing.
    1715                         // Why 'blocked' is returned for some PRs is not obvious.
     1714                        // All Good (but blocked due to Branch protection rules, or Merge requirements)
     1715                        // or Changes Requested
     1716                        // or Unit Tests Failing.
    17161717                        if (
    17171718                            data.reviews.CHANGES_REQUESTED ||
     
    17201721                                'failed' == Object.values( data.check_runs ).reduce( function( result, element ) {
    17211722                                    return 'failed' == element ? element : result;
    1722                                 } )
     1723                                }, 'no-reviews' )
    17231724                            )
    17241725                        ) {
Note: See TracChangeset for help on using the changeset viewer.