Changeset 9912

Timestamp:

05/25/2020 01:42:44 AM (5 years ago)

Author:

dd32

Message:

Trac: Handle PRs with no code reviews better.

Amends [9898].
See #5052.

File:

• sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -1712 +1712 @@
                         break;
                     case 'blocked':
-                        // All Good, Changes Requested, or unit tests failing.
-                        // Why 'blocked' is returned for some PRs is not obvious.
+                        // All Good (but blocked due to Branch protection rules, or Merge requirements)
+                        // or Changes Requested
+                        // or Unit Tests Failing.
                         if (
                             data.reviews.CHANGES_REQUESTED ||
@@ -1720 +1721 @@
                                 'failed' == Object.values( data.check_runs ).reduce( function( result, element ) {
                                     return 'failed' == element ? element : result;
-                                } )
+                                }, 'no-reviews' )
                             )
                         ) {